From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg KH <greg@kroah.com>,
rdunlap@xenotime.net, Achim_Leubner@adaptec.com,
joerg@dorchain.net, stable@kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [stable] [patch 29/29] bug in gdth.c crashing machine
Date: Wed, 07 Mar 2007 19:50:14 -0500 [thread overview]
Message-ID: <1173315014.3771.51.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <20070307111616.16e5e641.akpm@linux-foundation.org>
On Wed, 2007-03-07 at 11:16 -0800, Andrew Morton wrote:
> Achim did reply: http://lkml.org/lkml/2007/2/23/138
Ah ... OK; sorry, I'm parochial ... if it didn't appear on linux-scsi,
you can usually assume I haven't seen it.
> So we don't know what the patch does, but it should be merged into
> -stable
> (and mainline, heaven forfend)
Well ... I would, except what this patch does is to initialise the
command sg_ranz field (for both 64 bit and 32 bit commands). If you
look in the code just below the patch application at the
if (scp->use_sg) {
...
} else if (scp->request_bufflen) {
...
}
You'll find a line setting these parameters in each of the cases of the
if statement. So the bug appears to be that there's a missing else
clause to this if, which would initialise the zero transfer commands.
Is that a correct analysis?
James
next prev parent reply other threads:[~2007-03-08 0:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 10:46 [patch 29/29] bug in gdth.c crashing machine akpm
2007-03-07 17:28 ` James Bottomley
2007-03-07 17:40 ` [stable] " Greg KH
2007-03-07 19:16 ` Andrew Morton
2007-03-07 20:05 ` Joerg Dorchain
2007-03-08 0:50 ` James Bottomley [this message]
2007-03-09 18:36 ` Greg KH
2007-03-11 16:03 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173315014.3771.51.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=Achim_Leubner@adaptec.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=joerg@dorchain.net \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox