From: James Bottomley <James.Bottomley@SteelEye.com>
To: Joe Jin <joe.jin@oracle.com>
Cc: akpm@osdl.org, dgilbert@interlog.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, haobo.zhou@oracle.com
Subject: Re: [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd
Date: Thu, 08 Mar 2007 08:02:39 -0800 [thread overview]
Message-ID: <1173369759.3683.1.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <20070308092207.GA17141@joejin-pc.cn.oracle.com>
On Thu, 2007-03-08 at 17:22 +0800, Joe Jin wrote:
> While a scsi device hw error occured, device's status maybe setting
> to SDEV_OFFLINE, So at scsi_dispatch_cmd function, we should checking
> if device have offline, if yes, do nothing and just return error to
> user directly.
What's the error you're trying to fix? scsi_dispatch_cmd() is only
called from scsi_request_fn() which already has an equivalent of this
check in it just prior to calling dispatch.
James
next prev parent reply other threads:[~2007-03-08 16:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 9:22 [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd Joe Jin
2007-03-08 16:02 ` James Bottomley [this message]
2007-03-09 1:40 ` Joe Jin
2007-03-11 9:53 ` Andrew Morton
2007-03-12 2:52 ` Joe Jin
2007-03-12 3:15 ` Andrew Morton
2007-03-11 15:21 ` James Bottomley
2007-03-12 1:03 ` Joe Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173369759.3683.1.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=dgilbert@interlog.com \
--cc=haobo.zhou@oracle.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox