From: James Bottomley <James.Bottomley@SteelEye.com>
To: brking@linux.vnet.ibm.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [patch 1/1] scsi: Disable short inquiry log by default
Date: Mon, 02 Apr 2007 16:42:16 -0500 [thread overview]
Message-ID: <1175550136.3680.84.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <200704022120.l32LKOZU018499@d03av02.boulder.ibm.com>
On Mon, 2007-04-02 at 16:20 -0500, brking@linux.vnet.ibm.com wrote:
> If a scsi device reports less than 36 bytes of standard inquiry
> data, scsi core logs a KERN_INFO printk indicating this. It was
> observed that this results in lots of clutter in the log on
> systems with devices that respond to a SCSI Inquiry with PQ=3 or
> PQ=1 with less than 36 bytes of inquiry data, such as ibmvscsi.
> Disable this log by default.
It shouldn't be doing this ... the standards are pretty clear, say SPC-3
section 6.4.2
"The standard INQUIRY data shall contain at least 36 bytes"
Horrible things happen when this rule is violated (as it is by some
badly constructed devices), so I'd really like to leave the print in so
we know what we're debugging.
Can't you fix ibmvscsi to be standards compliant?
James
next prev parent reply other threads:[~2007-04-02 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-02 21:20 [patch 1/1] scsi: Disable short inquiry log by default brking
2007-04-02 21:35 ` Matthew Wilcox
2007-04-02 21:42 ` James Bottomley [this message]
2007-04-04 18:18 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175550136.3680.84.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox