From: James Bottomley <James.Bottomley@SteelEye.com>
To: David Miller <davem@davemloft.net>
Cc: aab@cichlid.com, cebbert@redhat.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
aradford@gmail.com
Subject: Re: Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13
Date: Fri, 06 Apr 2007 16:35:46 -0500 [thread overview]
Message-ID: <1175895346.3677.57.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <20070406.113229.122031524.davem@davemloft.net>
On Fri, 2007-04-06 at 11:32 -0700, David Miller wrote:
> From: James Bottomley <James.Bottomley@SteelEye.com>
> Date: Fri, 06 Apr 2007 10:27:57 -0500
>
> > On Fri, 2007-04-06 at 08:12 -0700, Andrew Burgess wrote:
> > > Yes. The 3w-xxxx.c driver changed between 2.6.18 and 2.6.20 but
> > > nothing jumps out to my untrained eyes. Here's the diff:
> > > Also, I should mention that the working kernel is a fedora
> > > rpm (2.6.18-1.2798.fc6) so I don't know what patches are in it.
> > > The vmlinuz is dated Oct 6 2006.
> >
> > It's actually a long standing bug in the 3w-xxxx driver. Apparently it
> > assumes request sense is always the use_sg == 0 case. This is what it
> > does on a request sense:
>
> Thanks for figuring this out James. I was very worried there
> was some bug in my scsi_send_eh_cmnd() fix :)
You're welcome ... the code in the fix looked fine, which is why I was
initially suspicious ... however, the bug in __free_page() on reversion
pretty much confirmed a driver issue.
James
next prev parent reply other threads:[~2007-04-06 21:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 15:12 Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13 Andrew Burgess
2007-04-06 15:27 ` James Bottomley
2007-04-06 18:32 ` David Miller
2007-04-06 21:35 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-04-06 18:18 Andrew Burgess
2007-04-06 15:51 Andrew Burgess
2007-04-06 16:14 ` James Bottomley
2007-04-06 16:32 ` Douglas Gilbert
2007-04-06 16:47 ` James Bottomley
2007-04-06 2:21 Andrew Burgess
2007-04-06 13:44 ` James Bottomley
2007-04-05 22:13 Andrew Burgess
2007-04-05 22:36 ` David Miller
2007-04-06 0:02 ` James Bottomley
2007-04-06 0:15 ` David Miller
2007-04-06 0:51 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175895346.3677.57.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=aab@cichlid.com \
--cc=aradford@gmail.com \
--cc=cebbert@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox