From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] add help to WAIT_SCAN option Date: Sat, 26 May 2007 19:29:30 -0500 Message-ID: <1180225770.3712.87.camel@mulgrave.il.steeleye.com> References: <20070526191127.GB7080@colo.lackof.org> <1180209014.3712.69.camel@mulgrave.il.steeleye.com> <20070527000637.GB31023@colo.lackof.org> <1180224943.3712.84.camel@mulgrave.il.steeleye.com> <20070527002710.GR5798@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from hancock.steeleye.com ([71.30.118.248]:51752 "EHLO hancock.sc.steeleye.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751198AbXE0A3c (ORCPT ); Sat, 26 May 2007 20:29:32 -0400 In-Reply-To: <20070527002710.GR5798@parisc-linux.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Matthew Wilcox Cc: Grant Grundler , linux-scsi@vger.kernel.org, Thibaut VARENE On Sat, 2007-05-26 at 18:27 -0600, Matthew Wilcox wrote: > On Sat, May 26, 2007 at 07:15:43PM -0500, James Bottomley wrote: > > Actually, it's a thinko on my part ... I thought late_initcall() and > > module_init() are the same level, and hence this would be link order > > dependent. Actually that's only true in the modular case, so the patch > > is fine ... I'll put it in. > > I disagree that Grant's patch is fine. Consider: > > - CONFIG_SCSI=y > - CONFIG_SCSI_SYM2=y > - CONFIG_SCSI_QLA2XYZ=m > > You want the root disc on your sym2 to be found, so you need > SCSI_WAIT_SCAN=y, but you also want to know when qla2xyz has finished > scanning the fabric, so you need SCSI_WAIT_SCAN=m. My patch doesn't > have this problem. Er .. I think you misunderstood the email. Grant asked why Hugh's (not Grant's) patch was wrong and I said that on reflection it wasn't. James