From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver Date: Tue, 17 Jul 2007 07:40:19 +1000 Message-ID: <1184622019.25235.81.camel@localhost.localdomain> References: <20070704132212.726923000@pademelon.sonytel.be> <1184335333.3402.20.camel@localhost.localdomain> <200707131619.54898.arnd@arndb.de> <1184340528.3402.32.camel@localhost.localdomain> <20070716121649.GI5195@kernel.dk> <1184593643.3447.9.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from gate.crashing.org ([63.228.1.57]:56380 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759514AbXGPVk5 (ORCPT ); Mon, 16 Jul 2007 17:40:57 -0400 In-Reply-To: <1184593643.3447.9.camel@localhost.localdomain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Jens Axboe , Arnd Bergmann , linux-scsi@vger.kernel.org, Linux Kernel Development , Alessandro Rubini , Linux/PPC Development , Paul Mackerras , Geert Uytterhoeven On Mon, 2007-07-16 at 08:47 -0500, James Bottomley wrote: > > No ... that was the point of flush_kernel_dcache_page(). The page in > question is page cache backed and contains user mappings. However, > the > block layer has already done a flush_dcache_page() in get_user_pages() > and the user shouldn't be touching memory under I/O (unless they want > self induced aliasing problems) so we're free to assume all the user > cachelines are purged, hence all we have to do is flush the kernel > alias > to bring the page up to date and make the users see it correctly. Ok. In our case the problem is not aliases though, it's the coherency between instruction and data caches for pages that may be executed from (such as swapped out text pages). Ben.