Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model

Christoph Hellwig
2007-07-31T14:57:26Z

On Tue, Jul 31, 2007 at 08:52:28AM -0600, Matthew Wilcox wrote:
> On Tue, Jul 31, 2007 at 09:42:25AM -0500, James Bottomley wrote:
> > Rather than changing this in every 53c700 based driver, shouldn't it
> > just be added to NCR_700_release()?
>
> Then I'd have to change the few drivers that weren't leaking scsi_hosts
> ;-) But I can, if that's what you prefer.

I don't think it's a good idea. scsi_hhost_put should be the very
last thing in the release method and all the drivers do some kind
of cleanup after detaching from the generic ncr53c00 driver.