Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model

Matthew Wilcox
2007-07-31T14:52:29Z

On Tue, Jul 31, 2007 at 09:42:25AM -0500, James Bottomley wrote:
> Rather than changing this in every 53c700 based driver, shouldn't it
> just be added to NCR_700_release()?

Then I'd have to change the few drivers that weren't leaking scsi_hosts
;-) But I can, if that's what you prefer.

> > diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
> > index 85f2394..27acef4 100644
> > --- a/drivers/scsi/aha152x.c
> > +++ b/drivers/scsi/aha152x.c
> > @@ -907,6 +907,7 @@ void aha152x_release(struct Scsi_Host *shpnt)
> > if(!shpnt)
> > return;
> >
> > + scsi_remove_host(shpnt);
> > if (shpnt->irq)
> > free_irq(shpnt->irq, shpnt);
>
> and this one needs to go via Boaz ... he's currently rewriting this
> driver.

OK.

--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."