Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model

Boaz Harrosh
2007-07-31T15:18:05Z

On 7/31/07, Matthew Wilcox <matthew@wil.cx> wrote:
> On Tue, Jul 31, 2007 at 09:42:25AM -0500, James Bottomley wrote:
> > Rather than changing this in every 53c700 based driver, shouldn't it
> > just be added to NCR_700_release()?
>
> > > diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
> > > index 85f2394..27acef4 100644
> > > --- a/drivers/scsi/aha152x.c
> > > +++ b/drivers/scsi/aha152x.c
> > > @@ -907,6 +907,7 @@ void aha152x_release(struct Scsi_Host *shpnt)
> > > if(!shpnt)
> > > return;
> > >
> > > + scsi_remove_host(shpnt);
> > > if (shpnt->irq)
> > > free_irq(shpnt->irq, shpnt);
> >
> > and this one needs to go via Boaz ... he's currently rewriting this
> > driver.
>
> OK.
>

It applies cleanly. I have not touched this area of code.
But maybe it's related to Randy's last problem of device
driver not unloading do to ref-count = 2. so please
wait a bit with this patch and we'll test it

And Thanks maybe it's the problem we where looking
for

Boaz