From: James Bottomley <James.Bottomley@SteelEye.com>
To: Lado <lpenko@gmx.de>
Cc: scsi <linux-scsi@vger.kernel.org>
Subject: Re: scsi: fix warning in scsi_sysfs.c
Date: Tue, 31 Jul 2007 17:39:12 -0500 [thread overview]
Message-ID: <1185921553.3468.57.camel@localhost.localdomain> (raw)
In-Reply-To: <200707312335.24919.lpenko@gmx.de>
On Tue, 2007-07-31 at 23:35 +0200, Lado wrote:
> Subject: scsi: fix warning in scsi_sysfs.c
>
> From: Ladislav Penko <lpenko@gmx.de>
>
> change: trivial fix warning (removed unused variable rq)
>
> Signed-off-by: Ladislav Penko <lpenko@gmx.de>
The trivial fixes aren't always the best. In this case, if you set
CONFIG_BLK_DEV_BSG=y you'll find the compile breaks with this fix. The
correct fix should already be upstream by now.
James
prev parent reply other threads:[~2007-07-31 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 21:35 scsi: fix warning in scsi_sysfs.c Lado
2007-07-31 22:39 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185921553.3468.57.camel@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=lpenko@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox