Re: [patch 13/30] nsp32_restart_autoscsi(): remove error check

[James Bottomley <James.Bottomley@SteelEye.com>]

On Fri, 2007-08-10 at 14:50 -0700, akpm@linux-foundation.org wrote:
> From: Adrian Bunk <bunk@stusta.de>
> 
> The Coverity checker noted that we'll anyway Oops later when we ran into
> this condition - and the error check didn't prevent that.
> 
> Considering that the error condition shouldn't be possible, and we are
> not able to handle it easily, this patch simply removes the pointless
> error check.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Cc: <yokota@netlab.is.tsukuba.ac.jp>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/scsi/nsp32.c |    4 ----
>  1 files changed, 4 deletions(-)
> 
> diff -puN drivers/scsi/nsp32.c~nsp32_restart_autoscsi-remove-error-check drivers/scsi/nsp32.c
> --- a/drivers/scsi/nsp32.c~nsp32_restart_autoscsi-remove-error-check
> +++ a/drivers/scsi/nsp32.c
> @@ -1905,10 +1905,6 @@ static void nsp32_restart_autoscsi(struc
>  
>  	nsp32_dbg(NSP32_DEBUG_RESTART, "enter");
>  
> -	if (data->cur_target == NULL || data->cur_lunt == NULL) {
> -		nsp32_msg(KERN_ERR, "Target or Lun is invalid");
> -	}
> -

I disagree pretty strongly with this ... you're not removing an error
check, you're removing a warning printk.  Before the driver would say
what the problem is and oops.  After, it will oops and you won't
necessarily know why.  I think that's a retrograde step.

James