From: James Bottomley <James.Bottomley@SteelEye.com>
To: James.Smart@Emulex.Com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.scsi.org, tore@linepro.no
Subject: Re: [PATCH] add container release logic - update fc transport to utilize it
Date: Tue, 14 Aug 2007 14:39:39 -0500 [thread overview]
Message-ID: <1187120379.3393.40.camel@localhost.localdomain> (raw)
In-Reply-To: <46C201CD.4000907@emulex.com>
On Tue, 2007-08-14 at 15:26 -0400, James Smart wrote:
> > Isn't a better way to handle it simply to give
> > transport_container_unregister() the semantics everyone is expecting
> > (i.e. to wait for everything to be tidied up and gone)? That way none
> > of the transport classes needs updating, and we don't have to handle the
> > rather nasty release and unload races.
>
> I was hoping you'd give some guidance. This area is black voodoo... :)
>
> Sure - so are you suggesting that transport_container_unregister()
> continually loop until successful ? If not, what other kind of semantic
> can we give it that we don't have to muck with the transport classes ?
Not looping no, but otherwise that's basically correct.
I was thinking of a wait_event driven system checking for
list_empty(cont->containers.k_list)
I'll cook up a patch.
James
prev parent reply other threads:[~2007-08-14 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-14 18:27 [PATCH] add container release logic - update fc transport to utilize it James Smart
2007-08-14 19:17 ` James Bottomley
2007-08-14 19:26 ` James Smart
2007-08-14 19:39 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187120379.3393.40.camel@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=James.Smart@Emulex.Com \
--cc=linux-kernel@vger.scsi.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tore@linepro.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox