Re: [RFC PATCH] SCSI: split Kconfig menu into two

Adrian Bunk
2007-09-15T13:53:04Z

On Sat, Sep 15, 2007 at 03:20:06PM +0200, Stefan Richter wrote:
> Adrian Bunk wrote:
> >>> There should first be the lowlevel SCSI, SATA, USB etc. drivers, these
> >>> drivers should select CONFIG_SCSI, and then the menu offering support
> >>> for disk, CD,...
> ...
> > If users who don't need it now enable CONFIG_SCSI (and drivers/ide/
> > usage is not that uncommon) that's a regression in the user interface.
>
> Aha, first all interconnects/transports are configured. If none of them
> 'select'ed SCSI, the menu for sd, sr, st stays invisible. Otherwise it
> is exposed.
>
> It still doesn't entirely clarify whether users need sd, sr, st, and
> whether thy need sd for the disk with root filesystem.

If you want to do it in a really perfect way, help texts aren't the
solution. You'll have to make the options like CONFIG_BLK_DEV_SR no
longer be user visible and select'ed through dummy options like e.g.:

config USB_STORAGE
tristate "USB Mass Storage support"
depends on USB
select SCSI
help
...

config USB_STORAGE_SD
tristate "USB Mass Storage hard disk support"
depends on USB_STORAGE
select BLK_DEV_SD
help
...

config USB_STORAGE_SR
tristate "USB Mass Storage CD/DVD support"
depends on USB_STORAGE
select BLK_DEV_SR
help
...

> Stefan Richter

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed