public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Anil K. Ravindranath" <anil_ravindranath@adaptec.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] aic7xxx driver. Restrict DMA to 32bit for 29320LPE Adaptec SCSI controller
Date: Fri, 21 Sep 2007 10:37:46 -0500	[thread overview]
Message-ID: <1190389066.3333.18.camel@localhost.localdomain> (raw)
In-Reply-To: <1190305223.1588.7.camel@linux.site>

please don't drop linux-scsi ... just because no-one else has asked the
question doesn't mean they're not interested in the answer.  Having the
answer in the list means that search tools can find it.

On Thu, 2007-09-20 at 09:20 -0700, Anil K. Ravindranath wrote: 
> Oh I see. I looked into the scsi_host_alloc(), now I see this.Thanks. By
> setting a dma_boundary to 4G, does it mean the kernel(in block) is
> ensuring that a DMA segment will not cross this 4G boundary. I mean a
> DMA segment will not be split at 4G boundary.

Yes, that's exactly what it means.  Primarily, as I said, because PCI
bridges can't necessarily span non-DAC to DAC in a single DMA transfer.

James


> With regards,
>   Anil
> 
> 
> On Thu, 2007-09-20 at 19:41 -0500, James Bottomley wrote:
> > On Thu, 2007-09-20 at 08:08 -0700, Anil K. Ravindranath wrote:
> > > Hi,
> > > 
> > > We have not heard any comments or inputs on this patch. 
> > > 
> > > With regards,
> > >   Anil
> > > 
> > > On Sat, 2007-06-30 at 05:45 -0700, Anil K. Ravindranath wrote:
> > > > Subject: [PATCH] aic7xxx driver. Restrict DMA to 32bit for 29320LPE
> > > > Adaptec SCSI controller
> > > > 
> > > > Contribution:
> > > > 
> > > > Anil Ravindranath <anil_ravindranath@adaptec.com>
> > > > 
> > > > Issue:
> > > > 
> > > > Data Bursts that cross from 32- to 64-Bit address space have incorrect
> > > > address for 29320LPE. This leads to potential data corruption.
> > 
> > Where do you think you see this happening?  The block layer has a
> > dma_boundary parameter (basically a mask which it refuses to allow dma
> > to cross).  By default this is set to 4GB (because a lot of PCI cards
> > have difficulty going from non-DAC to DAC).  The aic79xx driver does
> > nothing to alter this, so you shouldn't be seeing any DMA segments
> > crossing the 4GB boundary.
> > 
> > James
> > 
> > 


      parent reply	other threads:[~2007-09-21 15:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-30 12:45 [PATCH] aic7xxx driver. Restrict DMA to 32bit for 29320LPE Adaptec SCSI controller Anil K. Ravindranath
2007-09-20 15:08 ` Anil K. Ravindranath
2007-09-21  0:41   ` James Bottomley
     [not found]     ` <1190305223.1588.7.camel@linux.site>
2007-09-21 15:37       ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190389066.3333.18.camel@localhost.localdomain \
    --to=james.bottomley@steeleye.com \
    --cc=anil_ravindranath@adaptec.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox