From: Matthew Wilcox <willy@linux.intel.com>
To: linux-scsi@vger.kernel.org
Cc: Matthew Wilcox <matthew@wil.cx>, Matthew Wilcox <willy@linux.intel.com>
Subject: [PATCH] pluto: Don't abuse ->done for internal commands
Date: Tue, 25 Sep 2007 12:42:02 -0400 [thread overview]
Message-ID: <11907385243827-git-send-email-willy@linux.intel.com> (raw)
In-Reply-To: <1190738524460-git-send-email-willy@linux.intel.com>
From: Matthew Wilcox <matthew@wil.cx>
We can simply call the internal done function directly
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
---
drivers/scsi/pluto.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/pluto.c b/drivers/scsi/pluto.c
index e221389..0363c1c 100644
--- a/drivers/scsi/pluto.c
+++ b/drivers/scsi/pluto.c
@@ -160,7 +160,6 @@ int __init pluto_detect(struct scsi_host_template *tpnt)
SCpnt->request->cmd_flags &= ~REQ_STARTED;
- SCpnt->done = pluto_detect_done;
SCpnt->request_bufflen = 256;
SCpnt->request_buffer = fcs[i].inquiry;
PLD(("set up %d %08lx\n", i, (long)SCpnt))
@@ -195,7 +194,7 @@ int __init pluto_detect(struct scsi_host_template *tpnt)
SCpnt = &(fcs[i].cmd);
/* Let FC mid-level free allocated resources */
- SCpnt->done (SCpnt);
+ pluto_detect_scsi_done(SCpnt);
if (!SCpnt->result) {
struct pluto_inquiry *inq;
--
1.5.3.1
next prev parent reply other threads:[~2007-09-25 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 16:42 Remove ->done from scsi_cmnd Matthew Wilcox
2007-09-25 16:42 ` [PATCH] Fix mistaken uses of ->done Matthew Wilcox
2007-09-25 16:42 ` Matthew Wilcox [this message]
2007-09-25 16:42 ` [PATCH] gdth: Stop abusing ->done for internal commands Matthew Wilcox
2007-09-25 17:30 ` Boaz Harrosh
2007-09-25 17:33 ` Matthew Wilcox
2007-09-25 16:42 ` [PATCH] Get rid of scsi_cmnd->done Matthew Wilcox
2007-09-25 17:05 ` Boaz Harrosh
2007-09-25 17:09 ` Matthew Wilcox
2007-09-26 19:54 ` Remove ->done from scsi_cmnd Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11907385243827-git-send-email-willy@linux.intel.com \
--to=willy@linux.intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox