From: James Bottomley <James.Bottomley@SteelEye.com>
To: Michael Reed <mdr@sgi.com>
Cc: Jeff Garzik <jeff@garzik.org>, "Moore, Eric" <Eric.Moore@lsi.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 6/9] mpt fusion: error recovery improvements,andsynchronizing internal commands
Date: Tue, 25 Sep 2007 17:57:18 -0500 [thread overview]
Message-ID: <1190761038.8707.11.camel@localhost.localdomain> (raw)
In-Reply-To: <46F98DDB.8070407@sgi.com>
On Tue, 2007-09-25 at 17:38 -0500, Michael Reed wrote:
> Jeff Garzik wrote:
> > Moore, Eric wrote:
> >> On Tuesday, September 25, 2007 11:32 AM, James Bottomley wrote:
> >>
> >>>> Youve rejected the error recovery patchs, which is fair enough.
> >>> Just the separation ... the actual patch looks OK.
> >>>
> >>
> >> I'll will continue working to separate the "error recovery
> >> improvements:" into smaller feature add, but will take some time. I
> >> want some constructive feedback, and too big of patch is deterring some
> >> people from looking at it.
> >
> > I think it's fair to break it up, as long as its clearly noted that the
> > patch is for review only.
>
> Any chance the changes, properly documented, could be accepted as
> one big patch? Breaking this code into smaller patches, when it's
> really intended as a driver update, could prove problematic.
Yes, that's OK ... separate patches with signoffs are not absolute
requirements as long as the description and the heritage is in the
change log (although if you can do it, I prefer the separate signoffs
and distinct patches).
James
next prev parent reply other threads:[~2007-09-25 22:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 1:59 [PATCH 6/9] mpt fusion: error recovery improvements, and synchronizing internal commands Eric Moore
2007-09-22 16:01 ` James Bottomley
2007-09-25 1:35 ` [PATCH 6/9] mpt fusion: error recovery improvements, andsynchronizing " Moore, Eric
2007-09-25 17:35 ` James Bottomley
2007-09-22 16:22 ` [PATCH 6/9] mpt fusion: error recovery improvements, and synchronizing " James Bottomley
2007-09-25 1:26 ` [PATCH 6/9] mpt fusion: error recovery improvements, andsynchronizing " Moore, Eric
2007-09-25 17:32 ` James Bottomley
2007-09-25 18:22 ` [PATCH 6/9] mpt fusion: error recovery improvements,andsynchronizing " Moore, Eric
2007-09-25 18:37 ` Jeff Garzik
2007-09-25 22:38 ` Michael Reed
2007-09-25 22:57 ` James Bottomley [this message]
2007-09-25 23:31 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190761038.8707.11.camel@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=Eric.Moore@lsi.com \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mdr@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox