public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PATCH] SCSI bug fix for 2.6.23-rc8
Date: Tue, 25 Sep 2007 20:57:01 -0500	[thread overview]
Message-ID: <1190771821.8707.25.camel@localhost.localdomain> (raw)
In-Reply-To: <1190742924.3345.42.camel@localhost.localdomain>

On Tue, 2007-09-25 at 12:55 -0500, James Bottomley wrote:
> This is, unfortunately, not a recent regression but it's only been
> recently diagnosed.  Apparently the SCSI Parallel transport class domain
> validation cable width detection wasn't working, leading to cases where
> controllers with damaged cables would end up hanging the system (the
> reported one was an aic79xx controller, but the potential is there for
> all SPI based systems).  This bug would *only* affect systems whose
> cable integrity or connectors were compromised, so it isn't life
> threatening to every SCSI Parallel installation, but the consequence of
> running into it is a system hang.
> 
> The fix is available here:
> 
> master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git
> 
> The short changelog is:
> 
> James Bottomley (1):
>       scsi_transport_spi: fix domain validation failure from incorrect
> width setting
> 
> And the diffstat:
> 
>  scsi_transport_spi.c |   28 ++++++++++++++++++++++------
>  1 file changed, 22 insertions(+), 6 deletions(-)

We've had another late arriving bug fix:

commit ff4abd6cfacf0bb23a077f615d3a5cd17359db1b
Author: David Miller <davem@davemloft.net>
Date:   Fri Aug 24 22:25:58 2007 -0700

    [SCSI] esp: fix instance numbering.
    
    Because the ->unique_id is set too late, the ESP scsi host
    instance numbers in the kernel log during probing are
    wrong.
    
    Bug reported by Meelis Roos.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

Which I've added.  The diffstat is now:

 esp_scsi.c           |    3 ++-
 scsi_transport_spi.c |   28 ++++++++++++++++++++++------
 2 files changed, 24 insertions(+), 7 deletions(-)

James



      reply	other threads:[~2007-09-26  1:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-25 17:55 [GIT PATCH] SCSI bug fix for 2.6.23-rc8 James Bottomley
2007-09-26  1:57 ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190771821.8707.25.camel@localhost.localdomain \
    --to=james.bottomley@steeleye.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox