scsi-misc build breakage

scsi-misc build breakage

[Jeff Garzik]

current scsi-misc on i386 says:

drivers/scsi/arcmsr/arcmsr_hba.c:129: error: ‘arcmsr_pci_error_detected’ 
undeclared here (not in a function)
drivers/scsi/arcmsr/arcmsr_hba.c:130: error: ‘arcmsr_pci_slot_reset’ 
undeclared here (not in a function)
make[2]: *** [drivers/scsi/arcmsr/arcmsr_hba.o] Error 1
make[1]: *** [drivers/scsi/arcmsr] Error 2

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: scsi-misc build breakage

[James Bottomley]

On Wed, 2007-09-26 at 00:36 -0400, Jeff Garzik wrote:
> current scsi-misc on i386 says:
> 
> drivers/scsi/arcmsr/arcmsr_hba.c:129: error: ‘arcmsr_pci_error_detected’ 
> undeclared here (not in a function)
> drivers/scsi/arcmsr/arcmsr_hba.c:130: error: ‘arcmsr_pci_slot_reset’ 
> undeclared here (not in a function)
> make[2]: *** [drivers/scsi/arcmsr/arcmsr_hba.o] Error 1
> make[1]: *** [drivers/scsi/arcmsr] Error 2

That's my fault ... I took the templates out of the code because it was
giving warnings about static defined but unused functions.  I must be
compiling without CONFIG_SCSI_ARCMSR_AER.

This should fix it.

James

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index f4d2d52..449bceb 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -125,6 +125,10 @@ static struct scsi_host_template arcmsr_scsi_host_template = {
 	.shost_attrs		= arcmsr_host_attrs,
 };
 #ifdef CONFIG_SCSI_ARCMSR_AER
+static pci_ers_result_t arcmsr_pci_error_detected(struct pci_dev *pdev,
+						  pci_channel_state_t state);
+static pci_ers_result_t arcmsr_pci_slot_reset(struct pci_dev *pdev);
+
 static struct pci_error_handlers arcmsr_pci_error_handlers = {
 	.error_detected		= arcmsr_pci_error_detected,
 	.slot_reset		= arcmsr_pci_slot_reset,


-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html