public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SCSI: export sas_hash_addr()
Date: Thu, 27 Sep 2007 20:04:05 -0400	[thread overview]
Message-ID: <1190937846.5392.46.camel@localhost.localdomain> (raw)
In-Reply-To: <20070926073557.GA22773@havoc.gtf.org>

On Wed, 2007-09-26 at 03:35 -0400, Jeff Garzik wrote:
> sas_hash_addr() is the spec-defined standard hashing function.  Make it
> available to drivers that need it.

I'm not opposed in principle to exporting this, but I have a hard time
understanding why a driver would need it.

The hashed address is a property of the constructed SAS frames, which is
done in libsas.  The driver shouldn't really be calculating its own hash
instead of using what libsas provides ... or is this because the hashed
self address isn't calculated by the HBA so it needs to be programmed or
something?

James



  reply	other threads:[~2007-09-28  0:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26  7:35 [PATCH] SCSI: export sas_hash_addr() Jeff Garzik
2007-09-28  0:04 ` James Bottomley [this message]
2007-09-28  1:01   ` Jeff Garzik
2007-09-30 16:56     ` James Bottomley
2007-09-30 17:44       ` Jeff Garzik
2007-09-30 17:51         ` Jeff Garzik
2007-09-30 17:56         ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190937846.5392.46.camel@localhost.localdomain \
    --to=james.bottomley@steeleye.com \
    --cc=jeff@garzik.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox