From: James Bottomley <James.Bottomley@SteelEye.com>
To: Greg KH <greg@kroah.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
Alan Stern <stern@rowland.harvard.edu>,
Hannes Reinecke <hare@suse.de>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: BUG in: Driver core: convert block from raw kobjects to core devices (fwd)
Date: Wed, 31 Oct 2007 10:15:01 -0500 [thread overview]
Message-ID: <1193843701.3411.20.camel@localhost.localdomain> (raw)
In-Reply-To: <20071031143255.GC7076@kroah.com>
On Wed, 2007-10-31 at 07:32 -0700, Greg KH wrote:
> Hm, I seem to have missed the part in this thread where someone said
> that it was valid to have a parent reference a child device. That's
> just wrong and needs to be fixed. Is that in the scsi layer somewhere?
> The block layer? It sure isn't in the driver core...
This is the piece I'm still not clear on. It's something to do with the
gendisk. I'd have to look in block, but I believe the queue takes a ref
to the gendisk.
The scsi_device has a ref to the queue and the scsi_disk (in sd) has a
ref to both the scsi_device and the gendisk. That means, until sd is
unbound and the scsi_disk released, there's an implied unbreakable
reference chain.
at least, I think that's what the problem is.
James
next prev parent reply other threads:[~2007-10-31 15:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 15:18 BUG in: Driver core: convert block from raw kobjects to core devices (fwd) Alan Stern
2007-10-29 15:35 ` James Bottomley
2007-10-29 16:38 ` Alan Stern
2007-10-29 16:45 ` James Bottomley
2007-10-29 17:04 ` Alan Stern
2007-10-29 18:47 ` Alan Stern
2007-10-29 19:13 ` Kay Sievers
2007-10-31 4:25 ` Greg KH
2007-10-31 10:46 ` Kay Sievers
2007-10-31 14:32 ` Greg KH
2007-10-31 15:15 ` James Bottomley [this message]
2007-10-31 15:40 ` Kay Sievers
2007-10-31 15:47 ` James Bottomley
2007-10-31 16:04 ` Alan Stern
2007-10-31 16:13 ` James Bottomley
2007-10-31 16:24 ` Kay Sievers
2007-10-31 16:31 ` James Bottomley
2007-10-31 16:42 ` Kay Sievers
2007-10-31 16:46 ` James Bottomley
2007-10-31 17:32 ` Kay Sievers
2007-10-31 18:36 ` Alan Stern
2007-10-31 16:44 ` Alan Stern
2007-10-31 17:07 ` James Bottomley
2007-10-31 18:38 ` Alan Stern
2007-10-31 15:58 ` Alan Stern
2007-10-31 16:11 ` James Bottomley
2007-10-31 4:24 ` Greg KH
2007-10-31 15:51 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193843701.3411.20.camel@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=greg@kroah.com \
--cc=hare@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox