Re: [BUG] New Kernel Bugs

Re: [BUG] New Kernel Bugs

[James Bottomley]

On Tue, 2007-11-13 at 03:15 -0800, Andrew Morton wrote:
> >
> SCSI==================================================================
> > 
> > qla2xxx: driver initialization does not complete when booting with
> > Port connected
> > http://bugzilla.kernel.org/show_bug.cgi?id=9267
> > Kernel: 2.6.23.1
> 
> No response from developers

Urm, well, if no-one ever tells the SCSI list it's unrealistic to expect
anyone to be working on it.  As far as I can tell, email was sent to
Andrew Vasquez only on 31 October. However, the fault looks to be
generic, so he probably just dropped it.

This seems to be the significant line from the trace:

Oct  7 23:35:07 t-host kernel:   ISP2422: PCI-X Mode 1 (133 MHz) @
0000:01:03.0
hdma-, host#=1, fw=4.00.27 [IP] 
Oct  7 23:35:07 t-host kernel: ACPI: PCI Interrupt 0000:01:03.1[B] -> GSI 29
(level, low) -> IRQ 22
Oct  7 23:35:07 t-host kernel: qla2xxx 0000:01:03.1: Found an ISP2422, irq 22,
iobase 0xf8cf4000
Oct  7 23:35:07 t-host kernel: qla2xxx 0000:01:03.1: Configuring PCI space...
Oct  7 23:35:07 t-host kernel: qla2xxx 0000:01:03.1: Configure NVRAM
parameters...
Oct  7 23:35:07 t-host kernel: qla2xxx 0000:01:03.1: Verifying loaded RISC
code...
Oct  7 23:35:07 t-host kernel: qla2xxx 0000:01:03.1: Allocated (64 KB) for
EFT...
Oct  7 23:35:07 t-host kernel: qla2xxx 0000:01:03.1: Allocated (1413 KB) for
firmware dump...
Oct  7 23:35:07 t-host kernel: scsi2 : qla2xxx
Oct  7 23:35:07 t-host kernel: qla2xxx 0000:01:03.1: 
Oct  7 23:35:07 t-host kernel:  QLogic Fibre Channel HBA Driver: 8.01.07-k7
Oct  7 23:35:07 t-host kernel:   QLogic QLA2462 - PCI-X 2.0 to 4Gb FC, Dual
Channel
Oct  7 23:35:07 t-host kernel:   ISP2422: PCI-X Mode 1 (133 MHz) @ 0000:01:03.1
hdma-, host#=2, fw=4.00.27 [IP] 
Oct  7 23:35:07 t-host kernel: qla2xxx 0000:01:03.0: LIP reset occured (f8f7).
Oct  7 23:35:07 t-host kernel: qla2xxx 0000:01:03.0: LIP occured (f8f7).
Oct  7 23:35:07 t-host kernel: qla2xxx 0000:01:03.0: LOOP UP detected (4 Gbps).
Oct  7 23:35:07 t-host kernel: ohci_hcd 0000:03:00.0: auto-stop root hub
Oct  7 23:35:07 t-host kernel: ohci_hcd 0000:03:00.1: auto-stop root hub
Oct  7 23:35:07 t-host kernel: scsi 1:0:0:0: Direct-Access     transtec
PV610F16R1C      348B PQ: 0 ANSI: 4
Oct  7 23:35:07 t-host kernel: kobject_add failed for 1:0:0:0 with -EEXIST,
don't try to register things with the same name in the same directory.
Oct  7 23:35:07 t-host kernel:  [<c022c841>] kobject_shadow_add+0x111/0x190
Oct  7 23:35:07 t-host kernel:  [<c0286814>] device_add+0xc4/0x570
Oct  7 23:35:07 t-host kernel:  [<c02c90ce>] scsi_adjust_queue_depth+0x9e/0xf0
Oct  7 23:35:07 t-host kernel:  [<c02249b2>] __blk_queue_init_tags+0x32/0x70
Oct  7 23:35:07 t-host kernel:  [<c02d302f>] scsi_sysfs_add_sdev+0x4f/0x230
Oct  7 23:35:07 t-host kernel:  [<f8d93421>] qla2xxx_slave_configure+0x71/0x100
[qla2xxx]
Oct  7 23:35:07 t-host kernel:  [<c02d0ecf>] scsi_probe_and_add_lun+0xa5f/0xb40
Oct  7 23:35:07 t-host kernel:  [<c02d1559>] __scsi_scan_target+0xd9/0x6c0
Oct  7 23:35:07 t-host kernel:  [<c03a5be1>] schedule+0x2e1/0x950
Oct  7 23:35:07 t-host kernel:  [<c02d21f9>] scsi_scan_target+0xa9/0xe0
Oct  7 23:35:07 t-host kernel:  [<c02d5640>] fc_scsi_scan_rport+0x0/0x80
Oct  7 23:35:07 t-host kernel:  [<c02d56a9>] fc_scsi_scan_rport+0x69/0x80
Oct  7 23:35:07 t-host kernel:  [<c012b032>] run_workqueue+0x72/0x100
Oct  7 23:35:07 t-host kernel:  [<c012e8d0>] prepare_to_wait+0x20/0x70
Oct  7 23:35:07 t-host kernel:  [<c012b8c0>] worker_thread+0x0/0x100
Oct  7 23:35:07 t-host kernel:  [<c012b964>] worker_thread+0xa4/0x100
Oct  7 23:35:07 t-host kernel:  [<c012e720>] autoremove_wake_function+0x0/0x50
Oct  7 23:35:07 t-host kernel:  [<c012b8c0>] worker_thread+0x0/0x100
Oct  7 23:35:07 t-host kernel:  [<c012e462>] kthread+0x42/0x70
Oct  7 23:35:07 t-host kernel:  [<c012e420>] kthread+0x0/0x70
Oct  7 23:35:07 t-host kernel:  [<c0103573>] kernel_thread_helper+0x7/0x14
Oct  7 23:35:07 t-host kernel:  =======================
Oct  7 23:35:07 t-host kernel: error 1

It looks like some type of sysfs/kobject race in SCSI ... and I think we
might have seen it before, just not able to reproduce it reliably.

My bet would be that the LIP which acts like a reset and occurs in the
middle of the scan and so the initialising object is killed on the first
scan but not yet dead and then can't be re-added on the second scan.

Hannes has patches to help with this, but they're rather complex, and
not really 2.6.24 material.  I could see if there's a simpler fix.

James

Re: [BUG] New Kernel Bugs

[Randy Dunlap]

On Tue, 13 Nov 2007 09:33:21 -0600 James Bottomley wrote:

> On Tue, 2007-11-13 at 03:15 -0800, Andrew Morton wrote:
> > >
> > SCSI==================================================================
> > > 
> > > qla2xxx: driver initialization does not complete when booting with
> > > Port connected
> > > http://bugzilla.kernel.org/show_bug.cgi?id=9267
> > > Kernel: 2.6.23.1
> > 
> > No response from developers
> 
> Urm, well, if no-one ever tells the SCSI list it's unrealistic to expect
> anyone to be working on it.  As far as I can tell, email was sent to
> Andrew Vasquez only on 31 October. However, the fault looks to be
> generic, so he probably just dropped it.

It seems that new SCSI bugs need to be sent to linux-scsi@vger.kernel.org.

Martin, can you arrange that to happen automatically instead of
Andrew having to do it manually?

---
~Randy

Re: [BUG] New Kernel Bugs

[Martin Bligh]

> > > http://bugzilla.kernel.org/show_bug.cgi?id=9267
> > > Kernel: 2.6.23.1
> >
> > No response from developers
>
> Urm, well, if no-one ever tells the SCSI list it's unrealistic to expect
> anyone to be working on it.  As far as I can tell, email was sent to
> Andrew Vasquez only on 31 October. However, the fault looks to be
> generic, so he probably just dropped it.

This is a technical issue with vger.kernel.org mailing lists that I've tried
addressing before - maybe davem can help fix it?

What I've tried doing is bouncing relevant postings from my procmail
filters to the list, but it seems to drop bounces (probably as spam).
Is there any way around this? (like can I get an exception to be allowed
to bounce stuff or mark it with some magic X-secret-knock: header?)

Re: [BUG] New Kernel Bugs

[Andrew Morton]

On Tue, 13 Nov 2007 09:46:08 -0800 "Martin Bligh" <mbligh@google.com> wrote:

> > > > http://bugzilla.kernel.org/show_bug.cgi?id=9267
> > > > Kernel: 2.6.23.1
> > >
> > > No response from developers
> >
> > Urm, well, if no-one ever tells the SCSI list it's unrealistic to expect
> > anyone to be working on it.  As far as I can tell, email was sent to
> > Andrew Vasquez only on 31 October. However, the fault looks to be
> > generic, so he probably just dropped it.

I looked at that one and decided not to forward it to anyone because it was
already sent to Andrew.  Oh well, sorry.

> This is a technical issue with vger.kernel.org mailing lists that I've tried
> addressing before - maybe davem can help fix it?
> 
> What I've tried doing is bouncing relevant postings from my procmail
> filters to the list, but it seems to drop bounces (probably as spam).
> Is there any way around this? (like can I get an exception to be allowed
> to bounce stuff or mark it with some magic X-secret-knock: header?)

Please let me know asap if/when this starts working so I don't start
forwarding duplicates everywhere.

Re: [BUG] New Kernel Bugs

[David Miller]

From: "Martin Bligh" <mbligh@google.com>
Date: Tue, 13 Nov 2007 09:46:08 -0800

> This is a technical issue with vger.kernel.org mailing lists that I've tried
> addressing before - maybe davem can help fix it?

I think the problem is that certain mail headers show up multiple
times and this makes it look like a looping email so we toss it.

I suspect the one you really need to block out is X-MailingList
or similar.

Why don't you do a few tries and I'll try to remember to keep an
eye out for the bounces?

Thanks.

[PATCH] debloat aic7xxx and aic79xx drivers (was: Re: [BUG] New Kernel Bugs)

[Denys Vlasenko]

[-- Attachment #1: Type: text/plain, Size: 1858 bytes --]

Hi Matthew, Hannes,

Any news on this? Where these patches stand now?
Are they accepted into linux-scsi?

On Wednesday 14 November 2007 13:39, Denys Vlasenko wrote:
> hi Matthew,
>
> On Wednesday 14 November 2007 06:35, Hannes Reinecke wrote:
> > Matthew Wilcox wrote:
> > > On Wed, Nov 14, 2007 at 12:46:20AM -0700, Denys Vlasenko wrote:
> > >> Finally they replied and asked to rediff it against their
> > >> git tree. I did that and sent patches back. No reply since then.
> > >>
> > >> And mind you, the patch is not trying to do anything
> > >> complex, it mostly moves code around, removes 'inline',
> > >> adds 'const'. What should I think about it?
> > >
> > > I'm waiting for an ACK/NAK from Hannes, the maintainer.  What should I
> > > do?
>
> You could have informed me about this, and I would talk to Hannes
> myself. This would free up your mind from keeping track of this
> particular patch.
> Parallelize development, prevent things from being forgotten.
>
>
> Hi Hannes,
>
> > I haven't actually been able to test it here (too busy, sorry). If
> > someone else confirms it does it's job then
> >
> > Acked-by: Hannes Reinecke <hare@suse.de>
>
> It's not in my mailbox on this machine, gladly we have lkml archived
> in the Net. Here is a positive tester report:
>
> http://lkml.org/lkml/2007/10/15/168:
>
> ======================
> Date	Mon, 15 Oct 2007 15:53:08 +0200
> From	Gabriel C <>
> Subject	Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers
>
> >> Compile tested and applies cleanly to 2.6.23.
> >> I don't have this hardware anymore and cannot run test these patches.
> >
> > I can test these patches on an aic7892 controller later on today if you
>
> want.
>
> Works fine for me tested on :
>
> 03:0e.0 SCSI storage controller [0100]: Adaptec AIC-7892P U160/m
> [9005:008f] (rev 02)
>
> Gabriel
> =======================

-- 
vda

[-- Attachment #2: scsi-misc-2.6-aic7xxx-1-debloat.patch.gz --]
[-- Type: application/x-gzip, Size: 18779 bytes --]

[-- Attachment #3: scsi-misc-2.6-aic7xxx-3-addconst.patch.gz --]
[-- Type: application/x-gzip, Size: 4281 bytes --]

[-- Attachment #4: scsi-misc-2.6-aic7xxx-2-addstatic.patch.gz --]
[-- Type: application/x-gzip, Size: 31942 bytes --]

Re: [PATCH] debloat aic7xxx and aic79xx drivers

[Hannes Reinecke]

Denys Vlasenko wrote:
> Hi Matthew, Hannes,
> 
> Any news on this? Where these patches stand now?
> Are they accepted into linux-scsi?
> 
> On Wednesday 14 November 2007 13:39, Denys Vlasenko wrote:
>> hi Matthew,
>>
>> On Wednesday 14 November 2007 06:35, Hannes Reinecke wrote:
>>> Matthew Wilcox wrote:
>>>> On Wed, Nov 14, 2007 at 12:46:20AM -0700, Denys Vlasenko wrote:
>>>>> Finally they replied and asked to rediff it against their
>>>>> git tree. I did that and sent patches back. No reply since then.
>>>>>
>>>>> And mind you, the patch is not trying to do anything
>>>>> complex, it mostly moves code around, removes 'inline',
>>>>> adds 'const'. What should I think about it?
>>>> I'm waiting for an ACK/NAK from Hannes, the maintainer.  What should I
>>>> do?
>> You could have informed me about this, and I would talk to Hannes
>> myself. This would free up your mind from keeping track of this
>> particular patch.
>> Parallelize development, prevent things from being forgotten.
>>
>>
>> Hi Hannes,
>>
>>> I haven't actually been able to test it here (too busy, sorry). If
>>> someone else confirms it does it's job then
>>>
>>> Acked-by: Hannes Reinecke <hare@suse.de>
>> It's not in my mailbox on this machine, gladly we have lkml archived
>> in the Net. Here is a positive tester report:
>>
>> http://lkml.org/lkml/2007/10/15/168:
>>
>> ======================
>> Date	Mon, 15 Oct 2007 15:53:08 +0200
>> From	Gabriel C <>
>> Subject	Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers
>>
>>>> Compile tested and applies cleanly to 2.6.23.
>>>> I don't have this hardware anymore and cannot run test these patches.
>>> I can test these patches on an aic7892 controller later on today if you
>> want.
>>
>> Works fine for me tested on :
>>
>> 03:0e.0 SCSI storage controller [0100]: Adaptec AIC-7892P U160/m
>> [9005:008f] (rev 02)
>>
>> Gabriel
>> =======================
> 
As it's been tested, you have my

Acked-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html