* [Patch 1/2] zfcp: fix dismissal of error recovery actions
@ 2007-11-15 12:57 Martin Peschke
0 siblings, 0 replies; only message in thread
From: Martin Peschke @ 2007-11-15 12:57 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi, Swen Schillig, Christof Schmitt
zfcp_erp_action_dismiss() used to ignore any actions in the ready list. This
is a bug. Any action superseded by a stronger action needs to be dismissed.
This patch changes zfcp_erp_action_dismiss() so that it dismisses actions
regardless of their list affiliation. The ERP thread is able to handle this.
It is important to kick the erp thread only for actions in the running list,
though, as an imbalance of wakeup signals would confuse the erp thread
otherwise.
Signed-off-by: Martin Peschke <mp3@de.ibm.com>
Acked-by: Swen Schillig <swen@vnet.ibm.com>
---
drivers/s390/scsi/zfcp_erp.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.24-rc2-git5.orig/drivers/s390/scsi/zfcp_erp.c
+++ linux-2.6.24-rc2-git5/drivers/s390/scsi/zfcp_erp.c
@@ -977,7 +977,9 @@ static void zfcp_erp_action_dismiss(stru
debug_text_event(adapter->erp_dbf, 2, "a_adis");
debug_event(adapter->erp_dbf, 2, &erp_action->action, sizeof (int));
- zfcp_erp_async_handler_nolock(erp_action, ZFCP_STATUS_ERP_DISMISSED);
+ erp_action->status |= ZFCP_STATUS_ERP_DISMISSED;
+ if (zfcp_erp_action_exists(erp_action) == ZFCP_ERP_ACTION_RUNNING)
+ zfcp_erp_action_ready(erp_action);
}
int
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-11-15 12:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-15 12:57 [Patch 1/2] zfcp: fix dismissal of error recovery actions Martin Peschke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox