public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Moore, Eric" <Eric.Moore@lsi.com>
Cc: Chris Friesen <cfriesen@nortel.com>,
	"Stephens, Larry" <Larry.Stephens@lsi.com>,
	linux-scsi@vger.kernel.org, dgilbert@interlog.com,
	DL-MPT Fusion Linux <DL-MPTFusionLinux@lsi.com>
Subject: RE: how to handle QUEUE_FULL/SAM_STAT_TASK_SET_FULL in userspace?
Date: Thu, 15 Nov 2007 16:47:53 -0600	[thread overview]
Message-ID: <1195166873.9519.11.camel@localhost.localdomain> (raw)
In-Reply-To: <664A4EBB07F29743873A87CF62C26D70B34664@NAMAIL4.ad.lsil.com>

On Thu, 2007-11-15 at 15:35 -0700, Moore, Eric wrote:
> > No.  When the command goes via SG_IO it bypasses all return status
> > processing (and QUEUE_FULL/BUSY is a return status).  When it's
> > submitted in the normal way (i.e. via a ULD) then the mid-layer
> > processes these returns to a retry strategy.
> > 
> 
> James - Today I'm working some other customer issue, and my target
> returns SAM_STAT_TASK_SET_FULL when sg_inq is sent.   I see about 10
> retries before the data is finally returned.  Who is issuing the retries
> to my driver?   Doesn't sg_inq (sg3_utils), use SG_IO ->
> scsi_execute_async-> scsi_softirq_done, where SAM_STAT_TASK_SET_FULL is
> translated to ADD_TO_MLQUEUE, then retried, regardless the fact that
> SG_DEFAULT_RETRIES equal zero.   Maybe I'm missing something, but I'm
> seeing retries.

No, you're not ... I'm not thinking straight about the disposition path.
There's another thing at work, which is the command default timeout,
when that exhausts we do return the status back to SG_IO; otherwise we
will follow the retry strategy in all cases.

Jmaes



      reply	other threads:[~2007-11-15 22:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-12 19:54 how to handle QUEUE_FULL/SAM_STAT_TASK_SET_FULL in userspace? Chris Friesen
2007-11-13 22:04 ` Chris Friesen
2007-11-13 22:34   ` Moore, Eric
2007-11-14 17:23     ` Chris Friesen
2007-11-14 22:45       ` Moore, Eric
2007-11-15 19:09         ` Chris Friesen
2007-11-15 19:43           ` James Smart
2007-11-15 19:59             ` Moore, Eric
2007-11-15 19:57           ` Moore, Eric
2007-11-15 21:59             ` Chris Friesen
2007-11-15 22:18               ` James Bottomley
2007-11-15 22:35                 ` Moore, Eric
2007-11-15 22:47                   ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1195166873.9519.11.camel@localhost.localdomain \
    --to=james.bottomley@steeleye.com \
    --cc=DL-MPTFusionLinux@lsi.com \
    --cc=Eric.Moore@lsi.com \
    --cc=Larry.Stephens@lsi.com \
    --cc=cfriesen@nortel.com \
    --cc=dgilbert@interlog.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox