linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Alistair John Strachan <alistair@devzero.co.uk>
Cc: linux-kernel@vger.kernel.org, Ali Akcaagac <aliakc@web.de>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Jamie Lenehan <lenehan@twibble.org>,
	Oliver Neukum <oliver@neukum.name>,
	dc395x@twibble.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 44/59] drivers/scsi: Add missing "space"
Date: Tue, 20 Nov 2007 07:17:34 -0800	[thread overview]
Message-ID: <1195571854.4675.131.camel@localhost> (raw)
In-Reply-To: <200711201039.45321.alistair@devzero.co.uk>

On Tue, 2007-11-20 at 10:39 +0000, Alistair John Strachan wrote:
> On Tuesday 20 November 2007 01:53:31 Joe Perches wrote:
> > diff --git a/drivers/scsi/NCR_D700.c b/drivers/scsi/NCR_D700.c
> > index 9e64b21..99403a6 100644
> > --- a/drivers/scsi/NCR_D700.c
> > +++ b/drivers/scsi/NCR_D700.c
> > @@ -182,7 +182,7 @@ NCR_D700_probe_one(struct NCR_D700_private *p, int
> > siop, int irq,
> >
> >  	hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL);
> >  	if (!hostdata) {
> > -		printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host"
> > +		printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host "
> >  		       "data, detatching\n", siop);
> >  		return -ENOMEM;
> >  	}
> 
> If you're going to sneak in unrelated spelling/grammar changes, you might as 
> well do it unilaterally.

 drivers/scsi/NCR_D700.c    |    4 ++--
 drivers/scsi/aic7xxx_old.c |    2 +-
 drivers/scsi/dc395x.c      |    2 +-
 drivers/scsi/hosts.c       |    2 +-
 drivers/scsi/iscsi_tcp.c   |    6 +++---
 drivers/scsi/scsi_proc.c   |    2 +-
 drivers/scsi/scsi_scan.c   |    2 +-
 7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/scsi/NCR_D700.c b/drivers/scsi/NCR_D700.c
index 9e64b21..36281c5 100644
--- a/drivers/scsi/NCR_D700.c
+++ b/drivers/scsi/NCR_D700.c
@@ -182,8 +182,8 @@ NCR_D700_probe_one(struct NCR_D700_private *p, int siop, int irq,
 
 	hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL);
 	if (!hostdata) {
-		printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host"
-		       "data, detatching\n", siop);
+		printk(KERN_ERR "NCR D700: SIOP%d: Failed to allocate host "
+		       "data, detaching\n", siop);
 		return -ENOMEM;
 	}
 
diff --git a/drivers/scsi/aic7xxx_old.c b/drivers/scsi/aic7xxx_old.c
index 8f8db5f..c79a452 100644
--- a/drivers/scsi/aic7xxx_old.c
+++ b/drivers/scsi/aic7xxx_old.c
@@ -3716,7 +3716,7 @@ aic7xxx_pci_intr(struct aic7xxx_host *p)
   pci_read_config_byte(p->pdev, PCI_STATUS + 1, &status1);
 
   if ( (status1 & DPE) && (aic7xxx_verbose & VERBOSE_MINOR_ERROR) )
-    printk(WARN_LEAD "Data Parity Error during PCI address or PCI write"
+    printk(WARN_LEAD "Data Parity Error during PCI address or PCI write "
       "phase.\n", p->host_no, -1, -1, -1);
   if ( (status1 & SSE) && (aic7xxx_verbose & VERBOSE_MINOR_ERROR) )
     printk(WARN_LEAD "Signal System Error Detected\n", p->host_no,
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index a9def6e..f98747c 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -1520,7 +1520,7 @@ static u8 start_scsi(struct AdapterCtlBlk* acb, struct DeviceCtlBlk* dcb,
 	}
 #endif
 	if (acb->active_dcb) {
-		dprintkl(KERN_DEBUG, "start_scsi: (pid#%li) Attempt to start a"
+		dprintkl(KERN_DEBUG, "start_scsi: (pid#%li) Attempt to start a "
 			"command while another command (pid#%li) is active.",
 			srb->cmd->serial_number,
 			acb->active_dcb->active_srb ?
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 24271a8..b53f681 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -141,7 +141,7 @@ int scsi_host_set_state(struct Scsi_Host *shost, enum scsi_host_state state)
  illegal:
 	SCSI_LOG_ERROR_RECOVERY(1,
 				shost_printk(KERN_ERR, shost,
-					     "Illegal host state transition"
+					     "Invalid host state transition "
 					     "%s->%s\n",
 					     scsi_host_state_name(oldstate),
 					     scsi_host_state_name(state)));
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 4bcf916..2e0d9a1 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -389,7 +389,7 @@ iscsi_r2t_rsp(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask)
 	}
 
 	if (r2t->data_length > session->max_burst)
-		debug_scsi("invalid R2T with data len %u and max burst %u."
+		debug_scsi("invalid R2T with data len %u and max burst %u. "
 			   "Attempting to execute request.\n",
 			    r2t->data_length, session->max_burst);
 
@@ -900,13 +900,13 @@ more:
 
 		memcpy(&recv_digest, conn->data, sizeof(uint32_t));
 		if (recv_digest != tcp_conn->in.datadgst) {
-			debug_tcp("iscsi_tcp: data digest error!"
+			debug_tcp("iscsi_tcp: data digest error! "
 				  "0x%x != 0x%x\n", recv_digest,
 				  tcp_conn->in.datadgst);
 			iscsi_conn_failure(conn, ISCSI_ERR_DATA_DGST);
 			return 0;
 		} else {
-			debug_tcp("iscsi_tcp: data digest match!"
+			debug_tcp("iscsi_tcp: data digest match! "
 				  "0x%x == 0x%x\n", recv_digest,
 				  tcp_conn->in.datadgst);
 			tcp_conn->in_progress = IN_PROGRESS_WAIT_HEADER;
diff --git a/drivers/scsi/scsi_proc.c b/drivers/scsi/scsi_proc.c
index bb6f051..781dc85 100644
--- a/drivers/scsi/scsi_proc.c
+++ b/drivers/scsi/scsi_proc.c
@@ -123,7 +123,7 @@ void scsi_proc_host_add(struct Scsi_Host *shost)
 	p = create_proc_read_entry(name, S_IFREG | S_IRUGO | S_IWUSR,
 			sht->proc_dir, proc_scsi_read, shost);
 	if (!p) {
-		printk(KERN_ERR "%s: Failed to register host %d in"
+		printk(KERN_ERR "%s: Failed to register host %d in "
 		       "%s\n", __FUNCTION__, shost->host_no,
 		       sht->proc_name);
 		return;
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 40ea71c..e0a47ed 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -1124,7 +1124,7 @@ static void scsi_sequential_lun_scan(struct scsi_target *starget,
 	unsigned int sparse_lun, lun, max_dev_lun;
 	struct Scsi_Host *shost = dev_to_shost(starget->dev.parent);
 
-	SCSI_LOG_SCAN_BUS(3, printk(KERN_INFO "scsi scan: Sequential scan of"
+	SCSI_LOG_SCAN_BUS(3, printk(KERN_INFO "scsi scan: Sequential scan of "
 				    "%s\n", starget->dev.bus_id));
 
 	max_dev_lun = min(max_scsi_luns, shost->max_lun);



      reply	other threads:[~2007-11-20 15:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1195523331-15303-1-git-send-email-joe@perches.com>
     [not found] ` <1195523331-15303-2-git-send-email-joe@perches.com>
     [not found]   ` <1195523331-15303-3-git-send-email-joe@perches.com>
     [not found]     ` <1195523331-15303-4-git-send-email-joe@perches.com>
     [not found]       ` <1195523331-15303-5-git-send-email-joe@perches.com>
     [not found]         ` <1195523331-15303-6-git-send-email-joe@perches.com>
     [not found]           ` <1195523331-15303-7-git-send-email-joe@perches.com>
     [not found]             ` <1195523331-15303-8-git-send-email-joe@perches.com>
     [not found]               ` <1195523331-15303-9-git-send-email-joe@perches.com>
     [not found]                 ` <1195523331-15303-10-git-send-email-joe@perches.com>
     [not found]                   ` <1195523331-15303-11-git-send-email-joe@perches.com>
     [not found]                     ` <1195523331-15303-12-git-send-email-joe@perches.com>
     [not found]                       ` <1195523331-15303-13-git-send-email-joe@perches.com>
     [not found]                         ` <1195523331-15303-14-git-send-email-joe@perches.com>
     [not found]                           ` <1195523331-15303-15-git-send-email-joe@perches.com>
     [not found]                             ` <1195523331-15303-16-git-send-email-joe@perches.com>
     [not found]                               ` <1195523331-15303-17-git-send-email-joe@perches.com>
     [not found]                                 ` <1195523331-15303-18-git-send-email-joe@perches.com>
     [not found]                                   ` <1195523331-15303-19-git-send-email-joe@perches.com>
     [not found]                                     ` <1195523331-15303-20-git-send-email-joe@perches.com>
     [not found]                                       ` <1195523331-15303-21-git-send-email-joe@perches.com>
     [not found]                                         ` <1195523331-15303-22-git-send-email-joe@perches.com>
     [not found]                                           ` <1195523331-15303-23-git-send-email-joe@perches.com>
     [not found]                                             ` <1195523331-15303-24-git-send-email-joe@perches.com>
     [not found]                                               ` <1195523331-15303-25-git-send-email-joe@perches.com>
     [not found]                                                 ` <1195523331-15303-26-git-send-email-joe@perches.com>
     [not found]                                                   ` <1195523331-15303-27-git-send-email-joe@perches.com>
     [not found]                                                     ` <1195523331-15303-28-git-send-email-joe@perches.com>
     [not found]                                                       ` <1195523331-15303-29-git-send-email-joe@perches.com>
     [not found]                                                         ` <1195523331-15303-30-git-send-email-joe@perches.com>
     [not found]                                                           ` <1195523331-15303-31-git-send-email-joe@perches.com>
     [not found]                                                             ` <1195523331-15303-32-git-send-email-joe@perches.com>
     [not found]                                                               ` <1195523331-15303-33-git-send-email-joe@perches.com>
     [not found]                                                                 ` <1195523331-15303-34-git-send-email-joe@perches.com>
     [not found]                                                                   ` <1195523331-15303-35-git-send-email-joe@perches.com>
     [not found]                                                                     ` <1195523331-15303-36-git-send-email-joe@perches.com>
     [not found]                                                                       ` <1195523331-15303-37-git-send-email-joe@perches.com>
     [not found]                                                                         ` <1195523331-15303-38-git-send-email-joe@perches.com>
     [not found]                                                                           ` <1195523331-15303-39-git-send-email-joe@perches.com>
     [not found]                                                                             ` <1195523331-15303-40-git-send-email-joe@perches.com>
     [not found]                                                                               ` <ee1678e1bc8b80b7ae420059fffc7241486ea91a.1195454434.git.joe@perches.com>
     [not found]                                                                                 ` <f9ffd78f5eb1f49e89fc578611de786ae7b9ac87.1195454436.git.joe@perches.com>
2007-11-20  1:48                                                                                   ` [PATCH 40/59] drivers/scsi/aic7xxx: Add missing "space" Joe Perches
2007-11-20  1:48                                                                                   ` Joe Perches
     [not found]                                                                                 ` <6cd7c30e31d1e1a732eeb7f08636afa5061d5f44.1195454436.git.joe@perches.com>
2007-11-20  1:48                                                                                   ` [PATCH 41/59] drivers/scsi/aic94xx: " Joe Perches
2007-11-20  1:48                                                                                   ` Joe Perches
     [not found]                                                                                 ` <0d5c0d474aaeba86c0899848a6eb16ef92d308bc.1195454436.git.joe@perches.com>
2007-11-20  1:48                                                                                   ` [PATCH 42/59] drivers/scsi/lpfc: " Joe Perches
2007-11-20  1:48                                                                                   ` Joe Perches
     [not found]                                                                                 ` <769fa1b17e5b66a91e59e7c5899b6747b39b5731.1195454436.git.joe@perches.com>
2007-11-20  1:48                                                                                   ` [PATCH 43/59] drivers/scsi/qla4xxx: " Joe Perches
2007-11-20  1:48                                                                                   ` Joe Perches
2007-11-20  1:53                                                                                   ` Joe Perches
2007-11-20  1:53                                                                                   ` Joe Perches
     [not found]                                                                                 ` <adb8f5a3245d3e618c861f99db3acd43362c92c7.1195454436.git.joe@perches.com>
2007-11-20  1:53                                                                                   ` [PATCH 44/59] drivers/scsi: " Joe Perches
2007-11-20  1:53                                                                                   ` Joe Perches
2007-11-20 10:39                                                                                     ` Alistair John Strachan
2007-11-20 15:17                                                                                       ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1195571854.4675.131.camel@localhost \
    --to=joe@perches.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=aliakc@web.de \
    --cc=alistair@devzero.co.uk \
    --cc=dc395x@twibble.org \
    --cc=lenehan@twibble.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=oliver@neukum.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).