From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] zfcp: add some internal zfcp adapter statistics Date: Sun, 25 Nov 2007 13:16:59 +0200 Message-ID: <1195989419.3427.11.camel@localhost.localdomain> References: <200710311133.52090.swen@vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from hancock.steeleye.com ([71.30.118.248]:38661 "EHLO hancock.sc.steeleye.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752237AbXKYLRE (ORCPT ); Sun, 25 Nov 2007 06:17:04 -0500 In-Reply-To: <200710311133.52090.swen@vnet.ibm.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Swen Schillig Cc: Christof Schmitt , linux-scsi@vger.kernel.org, Linux on 390 Port , linux-kernel On Wed, 2007-10-31 at 11:33 +0100, Swen Schillig wrote: > From: Swen Schillig > > add some statistics provided by the zFCP adapter to the sysfs > > The new zFCP adapter statistics provide a variety of information > about the virtual adapter (subchannel). In order to collect this information > the zFCP driver is extended on one side to query the adapter and > on the other side summarize certain values which can then be fetched on demand. > This information is made available via files(attributes) in the sysfs filesystem. > > The information provided by the new zFCP adapter statistics can be fetched > by reading from the following files in the sysfs filesystem > > /sys/class/scsi_host/host/seconds_active > /sys/class/scsi_host/host/requests > /sys/class/scsi_host/host/megabytes > /sys/class/scsi_host/host/utilization This lot all look like they belong in the FC transport class statistics (some even already exist there). > These are the statistics on a virtual adapter (subchannel) level. > In addition latency information is provided on a SCSI device level (LUN) which > can be found at the following location > > /sys/class/scsi_device//device/cmd_latency > /sys/class/scsi_device//device/read_latency > /sys/class/scsi_device//device/write_latency These look to duplicate to some degree the figures in /sys/block//stat. Isn't the block device the best place to gather these, if they're useful? Since user latencies should probably include elevator times. James