From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-scsi@vger.kernel.org, Albert Lee <albertcc@tw.ibm.com>,
Alan Stern <stern@rowland.harvard.edu>,
Tejun Heo <htejun@gmail.com>, Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [patch] SCSI: early detection of medium not present, updated
Date: Sat, 01 Dec 2007 16:24:59 +0200 [thread overview]
Message-ID: <1196519099.5977.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20071129151842.44c05b18.akpm@linux-foundation.org>
On Thu, 2007-11-29 at 15:18 -0800, Andrew Morton wrote:
> Guys, I have this marked as needed-in-2.6.24?
Could you wait on this a bit ... since it's such an old bug. The code
in question needs to be reworked (as the comment says). I think the
best rework is to have the caller pass in an optional struct
scsi_sense_header into scsi_test_unit_ready() instead of the hacky
media_may_be_present, so the one place that needs this will be able to
interpret the sense codes correctly.
I can do this when I get back home ... unfortunately, I'm in Aswan today
at an Internet café ... I'll be back in Cairo tomorrow, but my US system
seems to have fallen off the internet, so I might not be able to test
any patches I come up with. Worst case, I'll be back in Chicago on
Thursday.
James
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-12-01 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 23:18 [patch] SCSI: early detection of medium not present, updated Andrew Morton
2007-11-30 0:04 ` Tejun Heo
2007-11-30 3:26 ` Alan Stern
2007-12-01 14:24 ` James Bottomley [this message]
2007-12-01 15:55 ` Alan Stern
2007-12-02 17:10 ` James Bottomley
2007-12-02 20:02 ` Alan Stern
2007-12-05 16:06 ` James Bottomley
2007-12-07 15:51 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196519099.5977.3.camel@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox