From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH 27/30] blk_end_request: changing scsi (take 4) Date: Wed, 12 Dec 2007 07:55:16 -0500 Message-ID: <1197464116.4203.23.camel@localhost.localdomain> References: <20071211.175209.10128473.k-ueda@ct.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from hancock.steeleye.com ([71.30.118.248]:45695 "EHLO hancock.sc.steeleye.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751292AbXLLMzZ (ORCPT ); Wed, 12 Dec 2007 07:55:25 -0500 In-Reply-To: <20071211.175209.10128473.k-ueda@ct.jp.nec.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Kiyoshi Ueda Cc: jens.axboe@oracle.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, j-nomura@ce.jp.nec.com, bharrosh@panasas.com On Tue, 2007-12-11 at 17:52 -0500, Kiyoshi Ueda wrote: > This patch converts scsi mid-layer to use blk_end_request interfaces. > Related 'uptodate' arguments are converted to 'error'. > > As a result, the interface of internal function, scsi_end_request(), > is changed. This looks fine, as far as it goes. One of the things that might actually be useful in future is as well as communicating the error, the ability to say more information about what happened. For instance dm-mp needs to know whether the error is transport or device related (the former being retryable on a different path). James