From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] libsas: don't use made up error codes
Date: Mon, 31 Dec 2007 15:34:34 -0600 [thread overview]
Message-ID: <1199136874.3110.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20071231212553.GD6767@tree.beaverton.ibm.com>
On Mon, 2007-12-31 at 13:25 -0800, Darrick J. Wong wrote:
> On Sun, Dec 30, 2007 at 12:37:31PM -0600, James Bottomley wrote:
> > This is bad for two reasons:
> >
> > 1. If they're returned to outside applications, no-one knows what
> > they mean.
> > 2. Eventually they'll clash with the ever expanding standard error
> > codes.
> >
> > The problem error code in question is ETASK. I've replaced this by
> > ECOMM (communications error on send) a network error code that seems to
> > most closely relay what ETASK meant.
>
> Yay, cleanups :)
Don't get your hopes up ... this was just one that unavoidably crossed
my attention path while I was doing something else. I'm not going out
looking for these things ... mainly for fear of finding them in large
quantities.
James
prev parent reply other threads:[~2007-12-31 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-30 18:37 [PATCH] libsas: don't use made up error codes James Bottomley
2007-12-31 21:25 ` Darrick J. Wong
2007-12-31 21:34 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199136874.3110.1.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=djwong@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox