Re: An MCA ESP driver

[James Bottomley <James.Bottomley@HansenPartnership.com>]

On Wed, 2007-08-15 at 14:55 -0700, David Miller wrote:
> From: Matthew Wilcox <matthew@wil.cx>
> Date: Wed, 15 Aug 2007 11:26:00 -0600
> 
> > On Tue, Aug 07, 2007 at 12:26:04AM -0700, David Miller wrote:
> > > > -	struct sbus_dma		*dma;
> > > > +	union {
> > > > +		struct sbus_dma	*sbus_dma;
> > > > +		unsigned int	x86_dma;
> > > > +	};
> > > >  };
> > > 
> > > Feel free to make this a "void *dma_cookie" or similar.
> > > It's private to the bus front-end.
> > 
> > Hi Dave,
> > 
> > Could I just clarify; would you prefer it to be a void *?  I prefer the
> > anonymous union that I have there right now, but I'm not particularly
> > attached to it.  In particular, I don't really care to be casting ints
> > (x86) to pointers, but that's a matter of personal taste.
> 
> Alternatively, you could remove this member entirely, and
> make the front-end driver allocate a private area at the
> end of "struct esp" to use for whatever purpose it likes.
> 
> I'm mostly ambivalent, but if the member stays it should be
> some generic type rather than anything front-end specific
> like it is now.

Just a check up on this:  Matthew were you ever going to complete the
mca_94x conversion?  It's quite topical because it would be another
example driver for the m68k people to look at.

If not, I can probably complete the bits you haven't yet done, but it
would be nice to know.

Thanks,

James