From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: linux-scsi@vger.kernel.org, matthew@wil.cx
Subject: Re: [PATCH] sym8xx_2: Fixes call to wait_for_completion_timeout() with NULL argument
Date: Mon, 07 Jan 2008 16:39:35 -0600 [thread overview]
Message-ID: <1199745575.3126.50.camel@localhost.localdomain> (raw)
In-Reply-To: <20080107225619.59621db7.krzysztof.h1@poczta.fm>
On Mon, 2008-01-07 at 22:56 +0100, Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
>
> This patch fixes call to wait_for_completion_timeout()
> with NULL argument.
That doesn't seem to be at all what your patch is doing. I can't see
any case in the old code where wait_for_completion_timeout() could be
called with a NULL that you fix. What it seems you are doing is
altering the code to eliminate the finished_reset variable.
James
next prev parent reply other threads:[~2008-01-07 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 21:56 [PATCH] sym8xx_2: Fixes call to wait_for_completion_timeout() with NULL argument Krzysztof Helt
2008-01-07 22:39 ` James Bottomley [this message]
2008-01-08 6:40 ` [PATCH] sym8xx_2: kill compilation warning Krzysztof Helt
2008-01-08 15:35 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199745575.3126.50.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox