Re: [PATCH v3] scsi: core: clear driver private data when retry request

John Garry
2025-02-19T14:14:33Z

On 18/02/2025 18:10, Bart Van Assche wrote:
> On 2/18/25 4:13 AM, John Garry wrote:
>> TBH, I am not sure on the history here. Maybe Bart or Christoph knows,
>> but my impression is still that the priv data is only cleared once in
>> the lifetime of the request (from 1bad6c4a) - at prep time - and some
>> drivers may rely on that (not be cleared again). Unlikely, though.
>
> I'm not aware of any such drivers.
>
> Driver-private data was introduced together with the scsi-mq code. I'm
> not aware of a similar concept in the legacy SCSI core.

ok, fine. Indeed, to me, it does not make much sense to keep the data in
this structure persistent between retries anyway.

Thanks,
John