public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	megaraidlinux@lsi.com, linux-scsi@vger.kernel.org,
	sam@ravnborg.org, Mauro Carvalho Chehab <mchehab@infradead.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] megaraid: fix section mismatch
Date: Thu, 10 Jan 2008 22:45:35 -0600	[thread overview]
Message-ID: <1200026735.5337.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20080110161023.91bf7618.akpm@linux-foundation.org>

On Thu, 2008-01-10 at 16:10 -0800, Andrew Morton wrote:
> On Thu, 10 Jan 2008 14:33:16 -0800
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Change megaraid_pci_driver_g variable name so that it matches the modpost
> > whitelist that allows pointers to init text/data.
> > 
> > WARNING: vmlinux.o(.data+0x1a8e30): Section mismatch: reference to .init.text:megaraid_probe_one (between 'megaraid_pci_driver_g' and 'class_device_attr_megaraid_mbox_app_hndl')
> > 
> 
> All these patches fix references to possibly-discarded sections and hence
> fix possibly-serious bugs.  So all of them should go into 2.6.24.

Renaming a variable fixes a serious bug?  It quiets a spurious warning
from modpost, sure, but I hardly think that's -rc7 material.

James



  reply	other threads:[~2008-01-11  4:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 22:33 [PATCH] megaraid: fix section mismatch Randy Dunlap
2008-01-11  0:10 ` Andrew Morton
2008-01-11  4:45   ` James Bottomley [this message]
2008-01-11  4:51     ` Randy Dunlap
2008-01-11  4:57     ` Andrew Morton
2008-01-11  5:34       ` James Bottomley
2008-01-11  2:40 ` Patro, Sumant
2008-01-11 17:57 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200026735.5337.3.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=megaraidlinux@lsi.com \
    --cc=mingo@elte.hu \
    --cc=randy.dunlap@oracle.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox