Re: [PATCH] megaraid: fix section mismatch

[James Bottomley <James.Bottomley@HansenPartnership.com>]

On Thu, 2008-01-10 at 20:57 -0800, Andrew Morton wrote:
> On Thu, 10 Jan 2008 22:45:35 -0600 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> 
> > On Thu, 2008-01-10 at 16:10 -0800, Andrew Morton wrote:
> > > On Thu, 10 Jan 2008 14:33:16 -0800
> > > Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > 
> > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > > 
> > > > Change megaraid_pci_driver_g variable name so that it matches the modpost
> > > > whitelist that allows pointers to init text/data.
> > > > 
> > > > WARNING: vmlinux.o(.data+0x1a8e30): Section mismatch: reference to .init.text:megaraid_probe_one (between 'megaraid_pci_driver_g' and 'class_device_attr_megaraid_mbox_app_hndl')
> > > > 
> > > 
> > > All these patches fix references to possibly-discarded sections and hence
> > > fix possibly-serious bugs.  So all of them should go into 2.6.24.
> > 
> > Renaming a variable fixes a serious bug?  It quiets a spurious warning
> > from modpost, sure, but I hardly think that's -rc7 material.
> > 
> 
> Rather than unerringly zooming in on the vanishingly trivial: will you be
> merging the advansys and qla2xx bugfixes or would you like me to?

You can ... looking at the advansys one, the isa driver remove will
always oops without the fix.  The qlogic one is less serious.

James