[PATCH] megaraid: fix section mismatch

[PATCH] megaraid: fix section mismatch

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Change megaraid_pci_driver_g variable name so that it matches the modpost
whitelist that allows pointers to init text/data.

WARNING: vmlinux.o(.data+0x1a8e30): Section mismatch: reference to .init.text:megaraid_probe_one (between 'megaraid_pci_driver_g' and 'class_device_attr_megaraid_mbox_app_hndl')

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/scsi/megaraid/megaraid_mbox.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.24-rc7-git1.orig/drivers/scsi/megaraid/megaraid_mbox.c
+++ linux-2.6.24-rc7-git1/drivers/scsi/megaraid/megaraid_mbox.c
@@ -300,7 +300,7 @@ static struct pci_device_id pci_id_table
 MODULE_DEVICE_TABLE(pci, pci_id_table_g);
 
 
-static struct pci_driver megaraid_pci_driver_g = {
+static struct pci_driver megaraid_pci_driver = {
 	.name		= "megaraid",
 	.id_table	= pci_id_table_g,
 	.probe		= megaraid_probe_one,
@@ -394,7 +394,7 @@ megaraid_init(void)
 
 
 	// register as a PCI hot-plug driver module
-	rval = pci_register_driver(&megaraid_pci_driver_g);
+	rval = pci_register_driver(&megaraid_pci_driver);
 	if (rval < 0) {
 		con_log(CL_ANN, (KERN_WARNING
 			"megaraid: could not register hotplug support.\n"));
@@ -415,7 +415,7 @@ megaraid_exit(void)
 	con_log(CL_DLEVEL1, (KERN_NOTICE "megaraid: unloading framework\n"));
 
 	// unregister as PCI hotplug driver
-	pci_unregister_driver(&megaraid_pci_driver_g);
+	pci_unregister_driver(&megaraid_pci_driver);
 
 	return;
 }

Re: [PATCH] megaraid: fix section mismatch

[Andrew Morton]

On Thu, 10 Jan 2008 14:33:16 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Change megaraid_pci_driver_g variable name so that it matches the modpost
> whitelist that allows pointers to init text/data.
> 
> WARNING: vmlinux.o(.data+0x1a8e30): Section mismatch: reference to .init.text:megaraid_probe_one (between 'megaraid_pci_driver_g' and 'class_device_attr_megaraid_mbox_app_hndl')
> 

All these patches fix references to possibly-discarded sections and hence
fix possibly-serious bugs.  So all of them should go into 2.6.24.

I already had the qla2xxx one.  It was sent to James a month ago with not
atypical results.  The advansys one is stuck in git-scsi-misc.

I'll give it 24 hours and then shall send these:

scsi-qla2xxx-qla_osc-section-fix.patch
megaraid-fix-section-mismatch.patch
cciss-section-mismatch.patch
x86-discover_ebda-section-mismatch.patch
tpm-infineon-section-mismatch.patch
dvb-av7110-fix-section-mismatch.patch
hostap-section-mismatch-warning.patch

in to Linus.

RE: [PATCH] megaraid: fix section mismatch

[Patro, Sumant]

Ack.

--Sumant 

-----Original Message-----
From: Randy Dunlap [mailto:randy.dunlap@oracle.com] 
Sent: Thursday, January 10, 2008 2:33 PM
To: DL-MegaRAID Linux; scsi
Cc: jejb; akpm; samr
Subject: [PATCH] megaraid: fix section mismatch

From: Randy Dunlap <randy.dunlap@oracle.com>

Change megaraid_pci_driver_g variable name so that it matches the
modpost whitelist that allows pointers to init text/data.

WARNING: vmlinux.o(.data+0x1a8e30): Section mismatch: reference to
.init.text:megaraid_probe_one (between 'megaraid_pci_driver_g' and
'class_device_attr_megaraid_mbox_app_hndl')

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/scsi/megaraid/megaraid_mbox.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.24-rc7-git1.orig/drivers/scsi/megaraid/megaraid_mbox.c
+++ linux-2.6.24-rc7-git1/drivers/scsi/megaraid/megaraid_mbox.c
@@ -300,7 +300,7 @@ static struct pci_device_id pci_id_table
MODULE_DEVICE_TABLE(pci, pci_id_table_g);
 
 
-static struct pci_driver megaraid_pci_driver_g = {
+static struct pci_driver megaraid_pci_driver = {
 	.name		= "megaraid",
 	.id_table	= pci_id_table_g,
 	.probe		= megaraid_probe_one,
@@ -394,7 +394,7 @@ megaraid_init(void)
 
 
 	// register as a PCI hot-plug driver module
-	rval = pci_register_driver(&megaraid_pci_driver_g);
+	rval = pci_register_driver(&megaraid_pci_driver);
 	if (rval < 0) {
 		con_log(CL_ANN, (KERN_WARNING
 			"megaraid: could not register hotplug
support.\n")); @@ -415,7 +415,7 @@ megaraid_exit(void)
 	con_log(CL_DLEVEL1, (KERN_NOTICE "megaraid: unloading
framework\n"));
 
 	// unregister as PCI hotplug driver
-	pci_unregister_driver(&megaraid_pci_driver_g);
+	pci_unregister_driver(&megaraid_pci_driver);
 
 	return;
 }

Re: [PATCH] megaraid: fix section mismatch

[James Bottomley]

On Thu, 2008-01-10 at 16:10 -0800, Andrew Morton wrote:
> On Thu, 10 Jan 2008 14:33:16 -0800
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Change megaraid_pci_driver_g variable name so that it matches the modpost
> > whitelist that allows pointers to init text/data.
> > 
> > WARNING: vmlinux.o(.data+0x1a8e30): Section mismatch: reference to .init.text:megaraid_probe_one (between 'megaraid_pci_driver_g' and 'class_device_attr_megaraid_mbox_app_hndl')
> > 
> 
> All these patches fix references to possibly-discarded sections and hence
> fix possibly-serious bugs.  So all of them should go into 2.6.24.

Renaming a variable fixes a serious bug?  It quiets a spurious warning
from modpost, sure, but I hardly think that's -rc7 material.

James

Re: [PATCH] megaraid: fix section mismatch

[Randy Dunlap]

James Bottomley wrote:
> On Thu, 2008-01-10 at 16:10 -0800, Andrew Morton wrote:
>> On Thu, 10 Jan 2008 14:33:16 -0800
>> Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> Change megaraid_pci_driver_g variable name so that it matches the modpost
>>> whitelist that allows pointers to init text/data.
>>>
>>> WARNING: vmlinux.o(.data+0x1a8e30): Section mismatch: reference to .init.text:megaraid_probe_one (between 'megaraid_pci_driver_g' and 'class_device_attr_megaraid_mbox_app_hndl')
>>>
>> All these patches fix references to possibly-discarded sections and hence
>> fix possibly-serious bugs.  So all of them should go into 2.6.24.
> 
> Renaming a variable fixes a serious bug?  It quiets a spurious warning
> from modpost, sure, but I hardly think that's -rc7 material.

Right.  The variable-renaming patches are for:

tpm_infineon
hostap
av7110
megaraid

The other 4 are more serious.

-- 
~Randy

Re: [PATCH] megaraid: fix section mismatch

[Andrew Morton]

On Thu, 10 Jan 2008 22:45:35 -0600 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> On Thu, 2008-01-10 at 16:10 -0800, Andrew Morton wrote:
> > On Thu, 10 Jan 2008 14:33:16 -0800
> > Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > 
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > 
> > > Change megaraid_pci_driver_g variable name so that it matches the modpost
> > > whitelist that allows pointers to init text/data.
> > > 
> > > WARNING: vmlinux.o(.data+0x1a8e30): Section mismatch: reference to .init.text:megaraid_probe_one (between 'megaraid_pci_driver_g' and 'class_device_attr_megaraid_mbox_app_hndl')
> > > 
> > 
> > All these patches fix references to possibly-discarded sections and hence
> > fix possibly-serious bugs.  So all of them should go into 2.6.24.
> 
> Renaming a variable fixes a serious bug?  It quiets a spurious warning
> from modpost, sure, but I hardly think that's -rc7 material.
> 

Rather than unerringly zooming in on the vanishingly trivial: will you be
merging the advansys and qla2xx bugfixes or would you like me to?

Re: [PATCH] megaraid: fix section mismatch

[James Bottomley]

On Thu, 2008-01-10 at 20:57 -0800, Andrew Morton wrote:
> On Thu, 10 Jan 2008 22:45:35 -0600 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> 
> > On Thu, 2008-01-10 at 16:10 -0800, Andrew Morton wrote:
> > > On Thu, 10 Jan 2008 14:33:16 -0800
> > > Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > 
> > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > > 
> > > > Change megaraid_pci_driver_g variable name so that it matches the modpost
> > > > whitelist that allows pointers to init text/data.
> > > > 
> > > > WARNING: vmlinux.o(.data+0x1a8e30): Section mismatch: reference to .init.text:megaraid_probe_one (between 'megaraid_pci_driver_g' and 'class_device_attr_megaraid_mbox_app_hndl')
> > > > 
> > > 
> > > All these patches fix references to possibly-discarded sections and hence
> > > fix possibly-serious bugs.  So all of them should go into 2.6.24.
> > 
> > Renaming a variable fixes a serious bug?  It quiets a spurious warning
> > from modpost, sure, but I hardly think that's -rc7 material.
> > 
> 
> Rather than unerringly zooming in on the vanishingly trivial: will you be
> merging the advansys and qla2xx bugfixes or would you like me to?

You can ... looking at the advansys one, the isa driver remove will
always oops without the fix.  The qlogic one is less serious.

James

Re: [PATCH] megaraid: fix section mismatch

[Sam Ravnborg]

On Thu, Jan 10, 2008 at 02:33:16PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Change megaraid_pci_driver_g variable name so that it matches the modpost
> whitelist that allows pointers to init text/data.
> 
> WARNING: vmlinux.o(.data+0x1a8e30): Section mismatch: reference to .init.text:megaraid_probe_one (between 'megaraid_pci_driver_g' and 'class_device_attr_megaraid_mbox_app_hndl')
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>