From: James Smart <James.Smart@Emulex.Com>
To: linux-scsi@vger.kernel.org
Subject: [PATCH] lpfc 8.2.4 fixup: always use stack waitqueue
Date: Mon, 14 Jan 2008 13:15:56 -0500 [thread overview]
Message-ID: <1200334556.395.1.camel@localhost.localdomain> (raw)
Found one area that needed to be fixed in the 8.2.4 patches.
Remove incorrect use of #ifdef for an on stack waitqueue. Upstream driver
always uses DECLARE_WAIT_QUEUE_HEAD_ONSTACK();
Signed-off-by: James Smart <James.Smart@emulex.com>
diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
--- a/drivers/scsi/lpfc/lpfc_scsi.c 2008-01-14 13:06:49.000000000 -0500
+++ b/drivers/scsi/lpfc/lpfc_scsi.c 2008-01-14 13:11:06.000000000 -0500
@@ -1041,12 +1041,7 @@ lpfc_abort_handler(struct scsi_cmnd *cmn
struct lpfc_scsi_buf *lpfc_cmd;
IOCB_t *cmd, *icmd;
int ret = SUCCESS;
-#ifdef DECLARE_WAIT_QUEUE_HEAD_ONSTACK
DECLARE_WAIT_QUEUE_HEAD_ONSTACK(waitq);
-#else
- DECLARE_WAIT_QUEUE_HEAD(waitq);
-#endif
-
lpfc_block_error_handler(cmnd);
lpfc_cmd = (struct lpfc_scsi_buf *)cmnd->host_scribble;
reply other threads:[~2008-01-14 18:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200334556.395.1.camel@localhost.localdomain \
--to=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox