public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jens Axboe <Jens.Axboe@oracle.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Actually using the sg table/chain code
Date: Tue, 15 Jan 2008 09:52:17 -0600	[thread overview]
Message-ID: <1200412337.9273.28.camel@localhost.localdomain> (raw)

I thought, now we had this new shiny code to increase the scatterlist
table size I'd try it out.  It turns out there's a pretty vast block
conspiracy that prevents us going over 128 entries in a scatterlist.

The first problems are in SCSI:  The host parameters sg_tablesize and
max_sectors are used to set the queue limits max_hw_segments and
max_sectors respectively (the former is the maximum number of entries
the HBA can tolerate in a scatterlist for each transaction, the latter
is a total transfer cap on the maxiumum number of 512 byte sectors).
The default settings, assuming the HBA doesn't vary them are
sg_tablesize at SG_ALL (255) and max_sectors at SCSI_DEFAULT_MAX_SECTORS
(1024).  A quick calculation shows the latter is actually 512k or 128
pages (at 4k pages), hence the persistent 128 entry limit.

However, raising max_sectors and sg_tablesize together still doesn't
help:  There's actually an insidious limit sitting in the block layer as
well.  This is what blk_queue_max_sectors says:

void blk_queue_max_sectors(struct request_queue *q, unsigned int
max_sectors)
{
	if ((max_sectors << 9) < PAGE_CACHE_SIZE) {
		max_sectors = 1 << (PAGE_CACHE_SHIFT - 9);
		printk("%s: set to minimum %d\n", __FUNCTION__, max_sectors);
	}

	if (BLK_DEF_MAX_SECTORS > max_sectors)
		q->max_hw_sectors = q->max_sectors = max_sectors;
 	else {
		q->max_sectors = BLK_DEF_MAX_SECTORS;
		q->max_hw_sectors = max_sectors;
	}
}

So it imposes a maximum possible setting of BLK_DEF_MAX_SECTORS which is
defined in blkdev.h to .... 1024, thus also forcing the queue down to
128 scatterlist entries.

Once I raised this limit as well, I was able to transfer over 128
scatterlist elements during benchmark test runs of normal I/O (actually
kernel compiles seem best, they hit 608 scatterlist entries).

So my question, is there any reason not to raise this limit to something
large (like 65536) or even eliminate it altogether?

James



             reply	other threads:[~2008-01-15 15:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-15 15:52 James Bottomley [this message]
2008-01-15 16:09 ` Actually using the sg table/chain code Boaz Harrosh
2008-01-15 16:49   ` James Bottomley
2008-01-15 17:35     ` Boaz Harrosh
2008-01-16 14:01       ` Boaz Harrosh
2008-01-16 15:09         ` James Bottomley
2008-01-16 16:11           ` Boaz Harrosh
2008-01-16 16:37             ` Boaz Harrosh
2008-01-16 16:46               ` James Bottomley
2008-01-15 19:52 ` Jeff Garzik
2008-01-15 20:14   ` James Bottomley
2008-01-16 15:06 ` Jens Axboe
2008-01-16 15:47   ` James Bottomley
2008-01-16 16:08     ` Jens Axboe
2008-02-22 16:13     ` Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200412337.9273.28.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=Jens.Axboe@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox