From: James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
To: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
Cc: Hans de Goede <j.w.r.degoede-fbo2DhPpy/Q@public.gmane.org>,
Matthew Dharm
<mdharm-scsi-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org>,
Boaz Harrosh <bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>,
USB Storage list
<usb-storage-ijkIwGHArpdIPJnuZ7Njw4oP9KaGy4wf@public.gmane.org>,
USB development list
<linux-usb-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
David Brown
<usb-storage2-GijAUarxTbMdnm+yROfE0A@public.gmane.org>,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: PATCH: usb-storage-set-last-sector-bug-flag.patch
Date: Sun, 20 Jan 2008 15:03:28 -0600 [thread overview]
Message-ID: <1200863008.3105.30.camel@localhost.localdomain> (raw)
In-Reply-To: <20080120205625.GB28842-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
On Sun, 2008-01-20 at 12:56 -0800, Greg KH wrote:
> On Sun, Jan 20, 2008 at 11:27:29AM +0100, Hans de Goede wrote:
> > Hi all,
> >
> > This patch sets the last_sector_bug flag to 1 for all USB disks. This is
> > needed to makes the cardreader on various HP multifunction printers work.
> >
> > Since the performance impact is negible we set this flag for all USB disks
> > to avoid an unusual_devs.h nightmare.
>
> Oh great, now my "working just fine" USB devices, which happen to have
> data in the last sector, suddenly stop working.
>
> That's not acceptable :(
I don't see how this will happen, might you not be confusing this change
(which allows access to the last sector, just insists that it be
accessed by a single sector read) with US_FL_FIX_CAPACITY which is for
devices that report having one more sectors than they actually have and
therefore adjusts the access limits down by one?
James
next prev parent reply other threads:[~2008-01-20 21:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-20 10:27 PATCH: usb-storage-set-last-sector-bug-flag.patch Hans de Goede
2008-01-20 20:56 ` Greg KH
[not found] ` <20080120205625.GB28842-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-01-20 21:03 ` James Bottomley [this message]
[not found] ` <1200863008.3105.30.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-01-20 21:25 ` Hans de Goede
2008-01-20 21:39 ` [usb-storage] " Guillaume Bedot
2008-01-20 21:45 ` Alan Stern
2008-01-23 18:12 ` Greg KH
[not found] ` <20080123181239.GA21836-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-01-23 18:39 ` James Bottomley
2008-01-23 18:50 ` Greg KH
2008-01-24 17:07 ` Stefan Richter
2008-01-24 17:21 ` Greg KH
2008-01-25 17:12 ` James Bottomley
2008-01-25 19:23 ` Matthew Dharm
[not found] ` <4798C5B4.1000208-MtYdepGKPcBMYopoZt5u/LNAH6kLmebB@public.gmane.org>
2008-01-24 17:22 ` Stefan Richter
[not found] ` <47932211.90105-fbo2DhPpy/Q@public.gmane.org>
2008-01-22 8:26 ` [usb-storage] " Guillaume Bedot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200863008.3105.30.camel@localhost.localdomain \
--to=james.bottomley-d9phhud1jfjcxq6kfmz53/egyhegw8jk@public.gmane.org \
--cc=bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=j.w.r.degoede-fbo2DhPpy/Q@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mdharm-scsi-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org \
--cc=usb-storage-ijkIwGHArpdIPJnuZ7Njw4oP9KaGy4wf@public.gmane.org \
--cc=usb-storage2-GijAUarxTbMdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).