From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Stuart Swales <stuart.swales@croftnuisk.co.uk>
Cc: linux-scsi@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 2.6.24-rc8-git6] initio module hangs on loading fix set
Date: Wed, 23 Jan 2008 17:45:00 -0600 [thread overview]
Message-ID: <1201131900.3110.111.camel@localhost.localdomain> (raw)
In-Reply-To: <47979CF0.7060104@croftnuisk.co.uk>
On Wed, 2008-01-23 at 20:00 +0000, Stuart Swales wrote:
> I've verified (on my Initio 9100 with a DAT drive) that the
> 2.6.24-rc8-git6 initio module still hangs on loading.
>
> These fixes (other than the printk) are needed to get the module to load
> ok (and work correctly) with my adapter & tape drive.
>
> a) printk cosmetic fix
>
> b) cblk->sglen needs setting for later DMA I/O routines to use
>
> c) host->bios_addr needs setting for debug output correctness
>
> d) semaph & semaph_lock initialisation had got lost since 2.6.22
>
> e) since 2.6.22 the bios data address was truncated to 16 bits (needs 20
> when shifted left)
That's brilliant, thanks! (Linus has been complaining about the broken
state of initio for a while, so this saves my bacon).
I made your patch actually apply (your mailer broke it in places) and
stripped out the comments, which won't make sense to anyone who doesn't
have the context of the actual patch to look at.
Thanks,
James
prev parent reply other threads:[~2008-01-23 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 20:00 [PATCH 2.6.24-rc8-git6] initio module hangs on loading fix set Stuart Swales
2008-01-23 23:45 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201131900.3110.111.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-scsi@vger.kernel.org \
--cc=stuart.swales@croftnuisk.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox