public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Ke Wei <kewei.mv@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
	linux-scsi@vger.kernel.org, kewei@marvell.com,
	qswang@marvell.com, jfeng@marvell.com, qzhao@marvell.com
Subject: Re: [PATCH] Marvell 6440 SAS/SATA driver
Date: Fri, 25 Jan 2008 17:00:03 -0600	[thread overview]
Message-ID: <1201302003.3119.81.camel@localhost.localdomain> (raw)
In-Reply-To: <6b2481670801250843g73ff3a6aydb465a654f53ad9d@mail.gmail.com>

On Sat, 2008-01-26 at 00:43 +0800, Ke Wei wrote:
> The attached is Marvell 6440 SAS/SATA driver. I will try to send email
> by git-send-email.
> 
> Changelog :
> Merged from Jeff's branch to James's branch.
> 
> Signed-off-by: Ke Wei <kewei@marvell.com>

A compile test of this seems to show some problems:

drivers/scsi/mvsas.c:2126: warning: 'mvs_read_port_irq_mask' defined but not used
drivers/scsi/mvsas.c:796: warning: 'mvs_hba_interrupt_enable' defined but not used
drivers/scsi/mvsas.c:1349: warning: 'mvs_free_reg_set' defined but not used

The lack of interrupt enable looks potentially fatal...except that you
have an open coded interrupt enable in mvs_hw_init().

James



  parent reply	other threads:[~2008-01-25 23:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080122151857.GA8680@ubuntu.domain>
2008-01-22 15:24 ` [PATCH] Marvell 6440 SAS/SATA driver Ke Wei
2008-01-23  3:58   ` Jeff Garzik
2008-01-23 10:54     ` Ke Wei
2008-01-23 11:41       ` Jeff Garzik
2008-01-25 16:43         ` Ke Wei
2008-01-25 17:24           ` Grant Grundler
2008-01-25 17:38             ` James Bottomley
2008-01-25 22:12             ` Jeff Garzik
2008-01-25 17:38           ` Grant Grundler
2008-01-25 22:39           ` James Bottomley
2008-01-27 15:10             ` Ke Wei
2008-01-27 15:27             ` Ke Wei
2008-01-27 18:13               ` James Bottomley
2008-02-05 13:19                 ` Ke Wei
2008-02-05 21:00                   ` Luben Tuikov
2008-02-07  0:33                   ` Jeff Garzik
2008-01-25 23:00           ` James Bottomley [this message]
2008-01-25 23:05             ` Jeff Garzik
2008-01-25 21:27       ` James Bottomley
2008-01-23 19:23     ` Grant Grundler
     [not found] <FE3F06125A99254E8D92161AA4569C6F02310B1A@sc-exch02.marvell.com>
2008-02-22 16:26 ` Jeff Garzik
2008-02-22 16:38   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201302003.3119.81.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=jeff@garzik.org \
    --cc=jfeng@marvell.com \
    --cc=kewei.mv@gmail.com \
    --cc=kewei@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=qswang@marvell.com \
    --cc=qzhao@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox