From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers Date: Thu, 31 Jan 2008 13:31:56 -0600 Message-ID: <1201807916.3131.42.camel@localhost.localdomain> References: <477CFC97.2010201@panasas.com> <477D0209.2000609@panasas.com> <1199384189.3122.22.camel@localhost.localdomain> <1199686061.31422.2.camel@kars.perseus.home> <1201802886.3131.35.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from accolon.hansenpartnership.com ([76.243.235.52]:53529 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbYAaTcD (ORCPT ); Thu, 31 Jan 2008 14:32:03 -0500 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Geert Uytterhoeven Cc: Kars de Jong , Linux/m68k , Boaz Harrosh , Christoph Hellwig , "Maciej W. Rozycki" , "David S. Miller" , linux-scsi On Thu, 2008-01-31 at 19:55 +0100, Geert Uytterhoeven wrote: > On Thu, 31 Jan 2008, James Bottomley wrote: > > On Mon, 2008-01-07 at 07:07 +0100, Kars de Jong wrote: > > > On do, 2008-01-03 at 20:05 +0100, Geert Uytterhoeven wrote: > > > > On Thu, 3 Jan 2008, James Bottomley wrote: > > > > > On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote: > > > > > > As recommended by Christoph Hellwig. There is no use > > > > > > of Fixing these drivers, since there is a much simpler > > > > > > and modern esp infrastructure with David Miller's esp_scsi > > > > > > > > > > > > - Remove all driver files dependent on NCR53C9x.c > > > > > > deleted: drivers/scsi/NCR53C9x.c > > > > > > deleted: drivers/scsi/NCR53C9x.h > > > > > > deleted: drivers/scsi/blz1230.c > > > > > > deleted: drivers/scsi/blz2060.c > > > > > > deleted: drivers/scsi/cyberstorm.c > > > > > > deleted: drivers/scsi/cyberstormII.c > > > > > > deleted: drivers/scsi/dec_esp.c > > > > > > deleted: drivers/scsi/fastlane.c > > > > > > deleted: drivers/scsi/mac_esp.c > > > > > > deleted: drivers/scsi/mca_53c9x.c > > > > > > deleted: drivers/scsi/oktagon_esp.c > > > > > > deleted: drivers/scsi/oktagon_io.S > > > > > > deleted: drivers/scsi/sun3x_esp.c > > > > > > > > > > > > - Remove above list from drivers/scsi/Kconfig && > > > > > > drivers/scsi/Makefile > > > > > > > > > > OK, I'll split this into four pieces for scsi-pending, since there are > > > > > three separate interest groups with signoffs to collect (MCA, m68k and > > > > > alpha) plus the core removal. > > > > > > > > Anybody who can look into converting the m68k NCR53C9x drivers and has > > > > hardware to test (some of) them? I don't think we can afford losing one > > > > third of our SCSI drivers... > > > > > > I'll have a look at this. I can only test it on Blizzard 1260 hardware > > > though. > > > > OK, time's up. > > > > These drivers are now unbuildable in mainline because of the promised > > sg_table updates. They either get removed, fixed or marked as BROKEN. > > Which is it to be? > > Is git smart enough to follow history between files that get removed and > readded? Yes. git revert on the removal changeset will re-add all the files and try to put the entries back into Kconfig and Makefile. > If yes, I think you can remove them. > If no, please mark them as BROKEN. OK ... I'll wave the magic wand. James