Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

Tejun Heo
2008-02-03T03:04:12Z

James Bottomley wrote:
> On Fri, 2008-02-01 at 15:02 -0500, Jeff Garzik wrote:
>> James Bottomley wrote:
>>> Could we please get this in ... I thought I mentioned several times that
>>> it fixes a fatal oops in both aic94xx and ipr.
>> Tejun has a persistent objection... see other email.
>
> Actually, see other email .. I meant that this patch (eliminate dma
> padding) is independent of the drain one.

Sorry about the delay.

There's a problem here. For the blk layer dma padding itself, it's okay
but the problem is that it blocks the pending draining patch without
supplying usable alternative at the moment. I agree that the long term
solution should be in the block layer && I understand that it causes
problem for SAS controllers but for the moment if we don't include the
existing draining patch, far more ATAPI devices are affected. So, it's
catch-22 situation.

I think the best solution is to update block layer draining such that it
can be included together before the merge window closes. I'll dig into it.

Thanks.

--
tejun