From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: akpm@linux-foundation.org
Cc: linux-scsi@vger.kernel.org, htejun@gmail.com,
kamalesh@linux.vnet.ibm.com
Subject: Re: [patch 01/13] git-scsi-misc: fix isa/pcmcia compile problem
Date: Tue, 05 Feb 2008 08:41:15 -0600 [thread overview]
Message-ID: <1202222475.3133.0.camel@localhost.localdomain> (raw)
In-Reply-To: <200802050752.m157qqYH010688@imap1.linux-foundation.org>
On Mon, 2008-02-04 at 23:53 -0800, akpm@linux-foundation.org wrote:
> From: Tejun Heo <htejun@gmail.com>
>
> aha152x.c and fdomain are built twice - once for the isa driver and once
> for the PCMCIA one. Through #ifdefs, the compiled codes are slightly
> different; thus, global symbols need to be given different names depending
> on which flavor is being built. This patch adds GLOBAL() macro to
> aha152x.h and fdomain.h which change the symbol depending on PCMCIA.
>
> This bug has always existed but has been masked by the fact the
> drivers/scsi/pcmcia used subdir-(y|m) instead of obj-(y|m) which made
> drivers/scsi/pcmcia/built_in.o not linked into the kernel and thus avoided
> the duplicate symbols during compilation.
>
> [akpm@linux-foundation.org: coding-style fixes]
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Tested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
An alternative fix for this is already in.
Author: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: Fri Jan 18 17:47:56 2008 -0600
[SCSI] fix pcmcia compile problem
James
prev parent reply other threads:[~2008-02-05 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 7:53 [patch 01/13] git-scsi-misc: fix isa/pcmcia compile problem akpm
2008-02-05 14:41 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202222475.3133.0.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox