From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Luben Tuikov <luben_tuikov@adaptec.com>
Subject: Re: ABORT_TASK defined in aic94xx_sas.h
Date: Wed, 06 Feb 2008 09:13:27 -0600 [thread overview]
Message-ID: <1202310808.3112.8.camel@localhost.localdomain> (raw)
In-Reply-To: <47A9B859.6020208@panasas.com>
On Wed, 2008-02-06 at 15:38 +0200, Boaz Harrosh wrote:
> include/scsi/scsi.h as a definition:
> #define ABORT_TASK 0x0d
>
> on the other hand drivers/scsi/aic94xx/aic94xx_sas.h has:
> #define ABORT_TASK 0x03
>
> am I right in thinking that aic94xx_sas.h is wrong in
> polluting the global name-space?
>
> If you ask me aic94xx_sas.h is a global name-space minefield
>
> (This gives me problems when trying to pull in scsi_eh.h into
> aic94xx source files)
Well, no, not in those terms. The global namespace exists in shared
headers which it's a little hard to argue that aic94xx_sas.h is, being
unusable by anything other than a single driver.
It is correct to say that include/scsi/scsi.h is polluting the global
namespace, because that is pulled into a large section of the kernel.
The message code #defines in scsi.h are a horrible mess of SPI message
defines and task management function defines each of which should
arguably have a SPI_ and TMF_ global namespace discriminator (and the
SPI_ ones be shovelled off into the SPI transport class header).
However, this looks like a reasonable hack.
James
next prev parent reply other threads:[~2008-02-06 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 13:38 ABORT_TASK defined in aic94xx_sas.h Boaz Harrosh
2008-02-06 15:13 ` James Bottomley [this message]
2008-02-06 15:34 ` Boaz Harrosh
2008-02-06 15:46 ` James Bottomley
2008-02-06 20:15 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202310808.3112.8.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
--cc=luben_tuikov@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox