Re: [patch 05/13] MegaRAID driver management char device moved to misc

[James Bottomley <James.Bottomley@HansenPartnership.com>]

On Mon, 2008-02-04 at 23:53 -0800, akpm@linux-foundation.org wrote:
> From: Thomas Horsten <thomas@horsten.com>
> 
> The MegaRAID driver's common management module (megaraid_mm.c) creates a
> char device used by the management tool "megarc" from LSI Logic (and
> possibly other management tools).
> 
> In 2.6 with udev, this device doesn't get created because it is not
> registered in sysfs.
> 
> I first fixed this by registering a class "megaraid_mm", but realized that
> this should probably be moved to misc devices, instead of taking up a char
> major.  This is because only 1 device is used, even if there are multiple
> adapters - the minor is never used (the adapter info is in the ioctl block
> sent to the driver, not detected based on the minor number as one might
> think).  So it is a complete waste to have an entire major taken by this.
> 
> So it now uses a misc device which I named "megadev0" (the name that megarc
> expects), and has a dynamic minor (previoulsy a dynamic major was used).
> 
> I have tested this on my own system with the megarc tool, and it works just
> as fine as before (only now the device gets created correctly by udev).
> 
> Cc: <thomas.horsten@gmail.com>
> Cc: Neela Syam Kolli <Neela.Kolli@engenio.com>
> Cc: "Ju, Seokmann" <Seokmann.Ju@lsil.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Neela and Sekomann or Sumant, can I ping on this ... I've no idea what
this will do to the raid management tools, so I really need someone to
sign off on this.

James