From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Sergio Luis <sergio@larces.uece.br>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
Achim Leubner <achim_leubner@adaptec.com>,
linux-scsi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device
Date: Tue, 12 Feb 2008 18:17:03 -0600 [thread overview]
Message-ID: <1202861823.3137.170.camel@localhost.localdomain> (raw)
In-Reply-To: <47B23033.1080100@larces.uece.br>
On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote:
> reposting an updated version of it. Please check if it's ok.
Looks fine, thanks! You added an extra space at the end of
while ((pdev = pci_get_device(vendor, device, pdev))
Which I fixed. Unfortunately checkpatch isn't very helpful for this
driver since it uses spaces not tabs everywhere, which checkpatch really
hates.
James
next prev parent reply other threads:[~2008-02-13 0:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 14:31 [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device Sergio Luis
2008-02-12 16:22 ` James Bottomley
2008-02-12 16:54 ` Boaz Harrosh
[not found] ` <47B23033.1080100@larces.uece.br>
2008-02-13 0:17 ` James Bottomley [this message]
2008-02-13 8:57 ` Boaz Harrosh
2008-02-16 16:37 ` Matthew Wilcox
2008-02-17 10:37 ` Boaz Harrosh
2008-02-17 16:42 ` Jeff Garzik
2008-03-04 7:48 ` Hannes Reinecke
2008-03-04 12:04 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202861823.3137.170.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=achim_leubner@adaptec.com \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sergio@larces.uece.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).