From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash Date: Wed, 13 Feb 2008 10:45:22 -0600 Message-ID: <1202921122.3109.31.camel@localhost.localdomain> References: <47A19E26.30107@panasas.com> <47B1D7A8.8010108@panasas.com> <47B1DA2A.1060904@panasas.com> <1202917468.3109.5.camel@localhost.localdomain> <47B312B3.3010200@panasas.com> <47B31BDE.2030408@panasas.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from accolon.hansenpartnership.com ([76.243.235.52]:56058 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758069AbYBMQpd (ORCPT ); Wed, 13 Feb 2008 11:45:33 -0500 In-Reply-To: <47B31BDE.2030408@panasas.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Boaz Harrosh Cc: Sven =?ISO-8859-1?Q?K=F6hler?= , Christoph Hellwig , Jeff Garzik , linux-scsi , linux-kernel@vger.kernel.org, Joerg Dorchain , Jon Chelton , Stefan Priebe - allied internet ag On Wed, 2008-02-13 at 18:33 +0200, Boaz Harrosh wrote: > On Wed, Feb 13 2008 at 17:54 +0200, Boaz Harrosh wrote: > > On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley wrote: > >> On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote: > >>> - gdth_flush(ha); > >>> - > >> This piece doesn't look right. gdth_flush() forces the internal cache > >> to disk backing. If you remove it, you're taking the chance that the > >> machine will be powered off without a writeback which can cause data > >> corruption. > >> > >> James > >> > > Yes. > > I have more problems reported, with exit, and am just sending one more patch that puts > > this back in. Which was tested. > > > > So I will resend this one plus one new one. > > > > Boaz > > > > The gdth driver would do a register_reboot_notifier(&gdth_notifier); > to a gdth_halt() function, which would then redo half of what gdth_exit > does, and wrongly so, and crash. > > Are we guaranteed in todays kernel that modules .exit function be called > on an halt or reboot? If so then there is no need for duplications and > the gdth_halt() should go. No. The __exit section is actually discardable if you promise never to remove the module. James