Re: [PATCH] Adaptec AACRAID: convert fibctx->wait_sem to completion

Matthias Kaehlcke
2008-02-13T20:15:27Z

El Wed, Feb 13, 2008 at 01:09:00PM -0600 James Bottomley ha dit:

> On Wed, 2008-02-13 at 19:34 +0100, Matthias Kaehlcke wrote:
> > Adaptec AACRAID driver: The semaphore fibctx->wait_sem is used for
> > signalling an event. Convert it to a completion.
>
> What's the purpose of doing this? The aacraid implementation seems to
> be a classic PV semaphore, so why does it need to become a completion?

i had another look at the code and i agree with you. i didn't realize that
the semaphore is used as counting semaphore

please redirect the patch to /dev/null

thanks for reviewing the patch and pointing out my mistake

--
Matthias Kaehlcke
Linux System Developer
Barcelona

In itself, homosexuality is as limiting as heterosexuality: the
ideal should be to be capable of loving a woman or a man; either,
a human being, without feeling fear, restraint, or obligation
(Simone de Beauvoir)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-