From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Daniel Drake <dsd@gentoo.org>
Cc: Joshua Hoblitt <josh@hoblitt.com>,
Kim H?jgaard-Hansen <kimhh@control.aau.dk>,
erich@areca.com.tw, linux-scsi@vger.kernel.org,
j_gentoo@hoblitt.com, nick.cheng@areca.com.tw
Subject: Re: arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings
Date: Sat, 16 Feb 2008 08:52:15 -0600 [thread overview]
Message-ID: <1203173535.3182.11.camel@localhost.localdomain> (raw)
In-Reply-To: <47B6CDDB.8000605@gentoo.org>
On Sat, 2008-02-16 at 11:49 +0000, Daniel Drake wrote:
> I assume you're aware that this patch is just a subset of commit
> 76d78300a6eb8 which you've already pushed up to Linus. Adding Nick Cheng
> (commit author) to CC so that he can go over the feedback.
Well, in case it's not obvious by now: The way to get bad code upstream
is to send a patch that combines many changes (the more the better) so
that any potential reviewer has no idea which change is meant by which
hunk and then to make sure Andrew picks it up so he'll hound the
subsystem Maintainer until it's applied. Best of all, mention that it
fixes a bug and you're made.
In this case, the problems with the changes weren't obvious to me until
I saw the broken out diff for the backport. (And incidentally, never
send URLs to code; 95% of people don't click on them. If you inline the
code, most people at least glance over it).
The odd thing is, it should have triggered a might_sleep() warning under
testing ... do you know why it didn't?
James
next prev parent reply other threads:[~2008-02-16 14:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 15:31 arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings Kim Højgaard-Hansen
2008-02-09 18:01 ` James Bottomley
2008-02-09 19:35 ` Joshua Hoblitt
2008-02-09 19:43 ` James Bottomley
2008-02-12 20:53 ` Joshua Hoblitt
2008-02-12 22:21 ` Joshua Hoblitt
2008-02-12 22:30 ` James Bottomley
2008-02-13 2:08 ` arcmsr + archttp64 calls dma_free_coherent() with irqsdisabled " nickcheng
2008-02-15 20:56 ` arcmsr + archttp64 calls dma_free_coherent() with irqs disabled " Joshua Hoblitt
2008-02-15 21:57 ` James Bottomley
2008-02-15 22:04 ` James Bottomley
2008-02-16 11:49 ` Daniel Drake
2008-02-16 14:52 ` James Bottomley [this message]
2008-02-16 23:36 ` Daniel Drake
2008-02-16 23:37 ` Daniel Drake
2008-02-17 1:15 ` Joshua Hoblitt
2008-02-19 20:38 ` Joshua Hoblitt
2008-02-13 12:55 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203173535.3182.11.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=dsd@gentoo.org \
--cc=erich@areca.com.tw \
--cc=j_gentoo@hoblitt.com \
--cc=josh@hoblitt.com \
--cc=kimhh@control.aau.dk \
--cc=linux-scsi@vger.kernel.org \
--cc=nick.cheng@areca.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox