Re: [PATCH] scsi_debug: disable clustering

Douglas Gilbert
2008-02-17T05:53:33Z

FUJITA Tomonori wrote:
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH] scsi_debug: disable clustering
>
> scsi_debug does at several places:
>
> for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) {
> kaddr = (unsigned char *)
> kmap_atomic(sg_page(sg), KM_USER0);
>
>
> We cannot do something like that with the clustering enabled (or we
> can use scsi_kmap_atomic_sg).
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

Thanks, Tomo.

Signed-off-by: Douglas Gilbert <dougg@torque.net>

> ---
> drivers/scsi/scsi_debug.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index 1541c17..d1777a9 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -222,7 +222,7 @@ static struct scsi_host_template sdebug_driver_template = {
> .cmd_per_lun = 16,
> .max_sectors = 0xffff,
> .unchecked_isa_dma = 0,
> - .use_clustering = ENABLE_CLUSTERING,
> + .use_clustering = DISABLE_CLUSTERING,
> .module = THIS_MODULE,
> };
>