From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Daniel Drake <dsd@gentoo.org>
Cc: josh@hoblitt.com, kimhh@control.aau.dk, erich@areca.com.tw,
linux-scsi@vger.kernel.org, nick.cheng@areca.com.tw
Subject: Re: [PATCH] arcmsr: fix message allocation
Date: Wed, 20 Feb 2008 10:28:42 -0600 [thread overview]
Message-ID: <1203524922.3109.34.camel@localhost.localdomain> (raw)
In-Reply-To: <20080220132905.EAA849D4144@zog.reactivated.net>
On Wed, 2008-02-20 at 13:29 +0000, Daniel Drake wrote:
> arcmsr_iop_message_xfer() is called from atomic context under the
> queuecommand scsi_host_template handler. James Bottomley pointed out
> that the current GFP_KERNEL|GFP_DMA flags are wrong: firstly we are in
> atomic context, secondly this memory is not used for DMA.
> Also removed some unneeded casts.
This looks good to me. It would be nice to have acks from Areca, but
I'll queue it for upstream fixes in a day or so regardless.
James
prev parent reply other threads:[~2008-02-20 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 13:29 [PATCH] arcmsr: fix message allocation Daniel Drake
2008-02-20 16:28 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203524922.3109.34.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=dsd@gentoo.org \
--cc=erich@areca.com.tw \
--cc=josh@hoblitt.com \
--cc=kimhh@control.aau.dk \
--cc=linux-scsi@vger.kernel.org \
--cc=nick.cheng@areca.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox