From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_scan: Convert GFP_ATOMIC to GFP_KERNEL
Date: Wed, 20 Feb 2008 13:45:37 -0600 [thread overview]
Message-ID: <1203536737.3109.38.camel@localhost.localdomain> (raw)
In-Reply-To: <20080220181029.GC27736@parisc-linux.org>
On Wed, 2008-02-20 at 11:10 -0700, Matthew Wilcox wrote:
> There is no need to allocate this memory atomically. There is no problem
> with sleeping during a bus scan, and it's actually causing problems
> for libata.
This bit is fine.
> Also remove the GFP_DMA flag. If it's needed, the block layer will
> bounce-buffer it.
Just because the block layer is capable of doing it doesn't mean we
should automatically force it. Bounce buffers are scarce resources, and
since we know they're required and we know that kmalloc allocates from
the top of its pools, and so will *always* require bouncing, doesn't it
make sense simply to save it the trouble?
James
prev parent reply other threads:[~2008-02-20 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 18:10 [PATCH] scsi_scan: Convert GFP_ATOMIC to GFP_KERNEL Matthew Wilcox
2008-02-20 19:45 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203536737.3109.38.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).