Re: [GIT PATCH] scsi fixes for 2.6.25-rc2

James Bottomley
2008-02-24T00:09:09Z

On Sat, 2008-02-23 at 18:31 -0500, Jeff Garzik wrote:
> Olof Johansson wrote:
> > Hi,
> >
> > On Sat, Feb 23, 2008 at 09:13:33AM -0600, James Bottomley wrote:
> >
> >> Jeff Garzik (1):
> >> mvsas: Add Marvell 6440 SAS/SATA driver
> > [...]
> >> drivers/scsi/mvsas.c | 2981 ++++++++++++++++++++++++++++++++++++
> >
> > I just noticed that the file permissions on that file are 755 in current
> > git, that was probably not intentional?
>
> Definitely not intentional. They were 0644 in the original changeset
> (the one from me you highlighted), then the second changeset updating
> mvsas somehow changed the perms.

Actually, unfortunately, it was ... I just didn't spot it. The second
patch has this in the header:

diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c
old mode 100644
new mode 100755

It's git slang for change the mode to executable ... no idea why marvell
would do that unless it's something windows related? Anyway, I'll
change it back.

James